Skip to content

Improve probe request diagnostics - #1427

Open
p-keminer wants to merge 2 commits into
justcallmekoko:developfrom
p-keminer:fix/probe-list-diagnostics
Open

Improve probe request diagnostics#1427
p-keminer wants to merge 2 commits into
justcallmekoko:developfrom
p-keminer:fix/probe-list-diagnostics

Conversation

@p-keminer

Copy link
Copy Markdown

Summary

  • expose the existing per-probe request count in list -p
  • render wildcard probe requests as <hidden> without changing named probes

Testing

  • Focused ESP32-C5 hardware test: list -p exposed plausible [REQ:n] counts; wildcard probes rendered as <hidden> while named probes remained unchanged.

Copilot AI lite review requested due to automatic review settings August 9, 2026 18:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves probe request diagnostics by standardizing how wildcard probe requests are displayed and by exposing the existing per-probe request counter in the CLI output (list -p).

Changes:

  • Print probe request ESSIDs after sanitization so wildcard requests render as <hidden> in probe scan output.
  • Extend list -p output to include the per-probe request count via a [REQ:n] prefix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
esp32_marauder/WiFiScan.cpp Prints the sanitized probe request ESSID (so empty/wildcard becomes <hidden>) rather than printing raw bytes as they are read.
esp32_marauder/CommandLine.cpp Updates list -p to display the stored per-probe requests counter alongside the ESSID.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread esp32_marauder/CommandLine.cpp
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.40%. Comparing base (66f3c81) to head (cfcbd60).
⚠️ Report is 27 commits behind head on develop.

Files with missing lines Patch % Lines
esp32_marauder/WiFiScan.cpp 0.00% 4 Missing ⚠️
esp32_marauder/CommandLine.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #1427      +/-   ##
==========================================
- Coverage     0.40%   0.40%   -0.01%     
==========================================
  Files           20      20              
  Lines        17176   17178       +2     
  Branches        11      11              
==========================================
  Hits            69      69              
- Misses       17103   17105       +2     
  Partials         4       4              
Flag Coverage Δ
firmware-unit-tests 0.40% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

esp32_marauder/WiFiScan.cpp:8155

  • checkEmptyProbe() maps an empty ESSID to "", so probe_req_essid.length() > 0 is always true here. This makes the conditional misleading and effectively dead code; the probe-request tracking below will always run anyway.

Consider removing the if wrapper and unindenting the body so the intent (always track probes, including hidden/wildcard) is clear.

          if (probe_req_essid.length() > 0) {

@p-keminer

Copy link
Copy Markdown
Author

All 22 firmware matrix builds and the Native Unity tests pass on this head. The remaining red statuses are limited to the repository-wide Codecov policy addressed separately in #1448.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants