Improve probe request diagnostics - #1427
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves probe request diagnostics by standardizing how wildcard probe requests are displayed and by exposing the existing per-probe request counter in the CLI output (list -p).
Changes:
- Print probe request ESSIDs after sanitization so wildcard requests render as
<hidden>in probe scan output. - Extend
list -poutput to include the per-probe request count via a[REQ:n]prefix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| esp32_marauder/WiFiScan.cpp | Prints the sanitized probe request ESSID (so empty/wildcard becomes <hidden>) rather than printing raw bytes as they are read. |
| esp32_marauder/CommandLine.cpp | Updates list -p to display the stored per-probe requests counter alongside the ESSID. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1427 +/- ##
==========================================
- Coverage 0.40% 0.40% -0.01%
==========================================
Files 20 20
Lines 17176 17178 +2
Branches 11 11
==========================================
Hits 69 69
- Misses 17103 17105 +2
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (1)
esp32_marauder/WiFiScan.cpp:8155
checkEmptyProbe()maps an empty ESSID to "", soprobe_req_essid.length() > 0is always true here. This makes the conditional misleading and effectively dead code; the probe-request tracking below will always run anyway.
Consider removing the if wrapper and unindenting the body so the intent (always track probes, including hidden/wildcard) is clear.
if (probe_req_essid.length() > 0) {
|
All 22 firmware matrix builds and the Native Unity tests pass on this head. The remaining red statuses are limited to the repository-wide Codecov policy addressed separately in #1448. |
Summary
list -p<hidden>without changing named probesTesting
list -pexposed plausible[REQ:n]counts; wildcard probes rendered as<hidden>while named probes remained unchanged.