Skip to content

Reject list saves when no SD card is available - #1429

Open
p-keminer wants to merge 1 commit into
justcallmekoko:developfrom
p-keminer:fix/reject-list-saves-without-sd
Open

Reject list saves when no SD card is available#1429
p-keminer wants to merge 1 commit into
justcallmekoko:developfrom
p-keminer:fix/reject-list-saves-without-sd

Conversation

@p-keminer

Copy link
Copy Markdown

Summary

  • reject saved-list writes immediately when SD support is unavailable
  • avoid reporting a successful save when no card is mounted

Testing

  • Focused ESP32-C5 hardware test: saves without detected SD media were rejected immediately without a false success message.

Scope

  • Later create, write, and flush failures are intentionally left to the transactional saved-list follow-up.

Copilot AI lite review requested due to automatic review settings August 9, 2026 18:43
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.40%. Comparing base (66f3c81) to head (daa5de7).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
esp32_marauder/WiFiScan.cpp 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #1429      +/-   ##
==========================================
- Coverage     0.40%   0.40%   -0.01%     
==========================================
  Files           20      20              
  Lines        17176   17197      +21     
  Branches        11      11              
==========================================
  Hits            69      69              
- Misses       17103   17124      +21     
  Partials         4       4              
Flag Coverage Δ
firmware-unit-tests 0.40% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves saved-list reliability by failing fast when SD functionality is not available at runtime, preventing “successful save” messages when no SD media is mounted.

Changes:

  • Add a shared helper to report SD-unavailable save failures via Serial (and screen when present).
  • Gate saved-list “Save As” flows (AirTags/APs/SSIDs) on sd_obj.supported to reject writes early.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread esp32_marauder/WiFiScan.cpp
@p-keminer

Copy link
Copy Markdown
Author

All 22 firmware matrix builds and the Native Unity tests pass on this head. The remaining red statuses are limited to the repository-wide Codecov policy addressed separately in #1448.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants