Reject list saves when no SD card is available - #1429
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1429 +/- ##
==========================================
- Coverage 0.40% 0.40% -0.01%
==========================================
Files 20 20
Lines 17176 17197 +21
Branches 11 11
==========================================
Hits 69 69
- Misses 17103 17124 +21
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR improves saved-list reliability by failing fast when SD functionality is not available at runtime, preventing “successful save” messages when no SD media is mounted.
Changes:
- Add a shared helper to report SD-unavailable save failures via Serial (and screen when present).
- Gate saved-list “Save As” flows (AirTags/APs/SSIDs) on
sd_obj.supportedto reject writes early.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
All 22 firmware matrix builds and the Native Unity tests pass on this head. The remaining red statuses are limited to the repository-wide Codecov policy addressed separately in #1448. |
Summary
Testing
Scope