Skip to content

Acknowledge added SSIDs before returning to the menu - #1430

Open
p-keminer wants to merge 1 commit into
justcallmekoko:developfrom
p-keminer:fix/add-ssid-return
Open

Acknowledge added SSIDs before returning to the menu#1430
p-keminer wants to merge 1 commit into
justcallmekoko:developfrom
p-keminer:fix/add-ssid-return

Conversation

@p-keminer

Copy link
Copy Markdown

Summary

  • show a persistent success acknowledgement after adding an SSID
  • return to WiFi General instead of reopening an empty input form
  • use a non-touch Returning... message where tap instructions are unavailable

Testing

  • Focused touch-hardware test: one SSID was added exactly once; the success screen remained until a fresh tap, returned without a bright intermediate frame, and cancel or empty input added nothing.
  • The non-touch return path was code/build covered, not separately exercised on hardware.

Copilot AI lite review requested due to automatic review settings August 9, 2026 18:43
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.40%. Comparing base (66f3c81) to head (eddbe17).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
esp32_marauder/MenuFunctions.cpp 0.00% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #1430      +/-   ##
==========================================
- Coverage     0.40%   0.40%   -0.01%     
==========================================
  Files           20      20              
  Lines        17176   17202      +26     
  Branches        11      11              
==========================================
  Hits            69      69              
- Misses       17103   17129      +26     
  Partials         4       4              
Flag Coverage Δ
firmware-unit-tests 0.40% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the “Add SSID” flow in the WiFi General menu by showing a clear success acknowledgement after an SSID is added, then returning the user to WiFi General instead of looping back into an empty SSID input prompt. It also adds a non-touch fallback message (“Returning...”) for builds where tap instructions aren’t applicable.

Changes:

  • Add an ILI9341-only acknowledgement screen (SSID added) with touch-to-continue behavior (or timed return for non-touch builds).
  • Stop the SSID input loop after a successful add, preventing the empty form from immediately reopening.
  • Return to wifiGeneralMenu explicitly after the add/cancel flow.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@p-keminer
p-keminer force-pushed the fix/add-ssid-return branch from 9ae9458 to eddbe17 Compare August 9, 2026 20:50
@p-keminer

Copy link
Copy Markdown
Author

All 22 firmware matrix builds and the Native Unity tests pass on this head. The remaining red statuses are limited to the repository-wide Codecov policy addressed separately in #1448.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants