Acknowledge added SSIDs before returning to the menu - #1430
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1430 +/- ##
==========================================
- Coverage 0.40% 0.40% -0.01%
==========================================
Files 20 20
Lines 17176 17202 +26
Branches 11 11
==========================================
Hits 69 69
- Misses 17103 17129 +26
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR improves the “Add SSID” flow in the WiFi General menu by showing a clear success acknowledgement after an SSID is added, then returning the user to WiFi General instead of looping back into an empty SSID input prompt. It also adds a non-touch fallback message (“Returning...”) for builds where tap instructions aren’t applicable.
Changes:
- Add an ILI9341-only acknowledgement screen (
SSID added) with touch-to-continue behavior (or timed return for non-touch builds). - Stop the SSID input loop after a successful add, preventing the empty form from immediately reopening.
- Return to
wifiGeneralMenuexplicitly after the add/cancel flow.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
9ae9458 to
eddbe17
Compare
|
All 22 firmware matrix builds and the Native Unity tests pass on this head. The remaining red statuses are limited to the repository-wide Codecov policy addressed separately in #1448. |
Summary
Returning...message where tap instructions are unavailableTesting