Confirm destructive clear actions - #1431
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1431 +/- ##
==========================================
- Coverage 0.40% 0.40% -0.01%
==========================================
Files 20 20
Lines 17176 17198 +22
Branches 11 11
==========================================
Hits 69 69
- Misses 17103 17125 +22
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR adds an explicit confirmation step before running destructive “clear” actions in the WiFi General menu (clearing stored SSIDs, APs, or stations), ensuring cancellation is non-destructive and returns the user back to the prior menu flow.
Changes:
- Introduces a reusable confirmation menu (
clearConfirmMenu) and helper (showClearConfirmation) to gate destructive clear operations behind a prompt. - Updates WiFi General menu “Clear …” actions (SSIDs/APs/stations) to route through the confirmation dialog before executing the clear.
- Adds a dedicated
clearStationsMenuto mirror the existing clear menus’ navigation behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| esp32_marauder/MenuFunctions.h | Adds new menu members and declares the showClearConfirmation helper. |
| esp32_marauder/MenuFunctions.cpp | Allocates/builds the new menus and wires WiFi General “clear” actions through the confirmation dialog. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
All 22 firmware matrix builds and the Native Unity tests pass on this head. The remaining red statuses are limited to the repository-wide Codecov policy addressed separately in #1448. |
Summary
Testing