Skip to content

Confirm destructive clear actions - #1431

Open
p-keminer wants to merge 1 commit into
justcallmekoko:developfrom
p-keminer:fix/confirm-destructive-clear-actions
Open

Confirm destructive clear actions#1431
p-keminer wants to merge 1 commit into
justcallmekoko:developfrom
p-keminer:fix/confirm-destructive-clear-actions

Conversation

@p-keminer

Copy link
Copy Markdown

Summary

  • require an explicit confirmation before clearing stored SSIDs, access points, or stations
  • keep cancellation non-destructive and return to the originating menu

Testing

  • Focused ESP32-C5 hardware tests covered cancel-without-delete and confirmed deletion for SSIDs.
  • AP and station confirmation dialogs were not recorded as separate hardware cases.

Copilot AI lite review requested due to automatic review settings August 9, 2026 18:43
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.40%. Comparing base (66f3c81) to head (2b4ccb0).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
esp32_marauder/MenuFunctions.cpp 0.00% 28 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #1431      +/-   ##
==========================================
- Coverage     0.40%   0.40%   -0.01%     
==========================================
  Files           20      20              
  Lines        17176   17198      +22     
  Branches        11      11              
==========================================
  Hits            69      69              
- Misses       17103   17125      +22     
  Partials         4       4              
Flag Coverage Δ
firmware-unit-tests 0.40% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an explicit confirmation step before running destructive “clear” actions in the WiFi General menu (clearing stored SSIDs, APs, or stations), ensuring cancellation is non-destructive and returns the user back to the prior menu flow.

Changes:

  • Introduces a reusable confirmation menu (clearConfirmMenu) and helper (showClearConfirmation) to gate destructive clear operations behind a prompt.
  • Updates WiFi General menu “Clear …” actions (SSIDs/APs/stations) to route through the confirmation dialog before executing the clear.
  • Adds a dedicated clearStationsMenu to mirror the existing clear menus’ navigation behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
esp32_marauder/MenuFunctions.h Adds new menu members and declares the showClearConfirmation helper.
esp32_marauder/MenuFunctions.cpp Allocates/builds the new menus and wires WiFi General “clear” actions through the confirmation dialog.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread esp32_marauder/MenuFunctions.cpp
@p-keminer

Copy link
Copy Markdown
Author

All 22 firmware matrix builds and the Native Unity tests pass on this head. The remaining red statuses are limited to the repository-wide Codecov policy addressed separately in #1448.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants