Skip to content

Add a station details view - #1437

Open
p-keminer wants to merge 1 commit into
justcallmekoko:developfrom
p-keminer:feat/station-info-view
Open

Add a station details view#1437
p-keminer wants to merge 1 commit into
justcallmekoko:developfrom
p-keminer:feat/station-info-view

Conversation

@p-keminer

Copy link
Copy Markdown

Summary

  • add a dedicated menu for stations currently held in memory
  • show the full raw MAC address, packet count, and selection state without lengthening the compact station list
  • adapt the details layout to small and larger displays

Testing

  • Focused ESP32-C5 hardware test: the compact row remained readable; details showed the full raw MAC, identity, and packet count without a misleading AP index or overlap, and both back paths worked.

Copilot AI lite review requested due to automatic review settings August 9, 2026 18:44
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 129 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.39%. Comparing base (66f3c81) to head (91f4d15).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
esp32_marauder/MenuFunctions.cpp 0.00% 129 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #1437      +/-   ##
==========================================
- Coverage     0.40%   0.39%   -0.01%     
==========================================
  Files           20      20              
  Lines        17176   17281     +105     
  Branches        11      11              
==========================================
  Hits            69      69              
- Misses       17103   17208     +105     
  Partials         4       4              
Flag Coverage Δ
firmware-unit-tests 0.39% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a dedicated “Station Info” flow to the on-device UI so users can browse stations currently held in memory and view a per-station details screen (full MAC, packet count, selected state) with layout adjustments for small vs larger displays.

Changes:

  • Introduces two new menus (wifiStationInfoMenu, stationInfoMenu) and wires them into the WiFi General menu.
  • Adds showStationInfo() to render a station details view (MAC/packets/selected) with compact vs roomy layouts.
  • Populates a station-selection menu from the in-memory stations list, with an empty-state message when none are present.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
esp32_marauder/MenuFunctions.h Adds new menu members and declares showStationInfo() used by the station details flow.
esp32_marauder/MenuFunctions.cpp Implements station details rendering and adds menu wiring/population for station selection + back navigation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread esp32_marauder/MenuFunctions.cpp
Comment thread esp32_marauder/MenuFunctions.cpp
@p-keminer

Copy link
Copy Markdown
Author

All 22 firmware matrix builds and the Native Unity tests pass on this head. The remaining red statuses are limited to the repository-wide Codecov policy addressed separately in #1448.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants