Skip to content

Correct the Flipper BLE advertisement data length - #1447

Draft
p-keminer wants to merge 2 commits into
justcallmekoko:developfrom
p-keminer:fix/flipper-ble-advertisement-length
Draft

Correct the Flipper BLE advertisement data length#1447
p-keminer wants to merge 2 commits into
justcallmekoko:developfrom
p-keminer:fix/flipper-ble-advertisement-length

Conversation

@p-keminer

Copy link
Copy Markdown

Stack

Summary

  • change the Flipper Manufacturer Specific Data AD length from 0x05 to 0x09

Protocol basis

The Bluetooth GAP format defines the length octet as the number of following data octets, with the first data octet being the AD type. This structure contains one type byte (0xFF), two company-ID bytes, and six manufacturer payload bytes: 1 + 2 + 6 = 9. See the Bluetooth Core Generic Access Profile.

Testing boundary

  • The corrected source was build-covered in the cumulative validation firmware.
  • The post-fix Android btsnoop contained no Flipper signature, likely due to filtering, so the corrected Flipper frame was not independently observed over the air.
  • This PR is intentionally a draft and does not claim a complete post-fix OTA pass.

@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.40%. Comparing base (66f3c81) to head (40c8441).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
esp32_marauder/WiFiScan.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1447   +/-   ##
=======================================
  Coverage     0.40%   0.40%           
=======================================
  Files           20      20           
  Lines        17176   17176           
  Branches        11      11           
=======================================
  Hits            69      69           
  Misses       17103   17103           
  Partials         4       4           
Flag Coverage Δ
firmware-unit-tests 0.40% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@p-keminer

Copy link
Copy Markdown
Author

All 22 firmware matrix builds and the Native Unity tests pass on this head. The remaining red statuses are limited to the repository-wide Codecov policy addressed separately in #1448.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant