Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: Endware functionality #51

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Added: Endware functionality #51

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ea3cb45
added: Endware functionality
Mar 25, 2020
af47ede
removed: unnecessary variable in Extend
Mar 25, 2020
f7a7a24
fixed: overflow from ServeHTTP calls
Mar 25, 2020
2cb09e0
added: tests
Mar 25, 2020
242520c
fixed: immutability issue with tests
Mar 25, 2020
b196bc7
updated: better immutability test
Mar 25, 2020
9659d70
updated: make([]Endware,0) -> ([]Endware)(nil)
Mar 25, 2020
d69ac3b
updated: tests to include After() call if it has a New()
Mar 25, 2020
561f6e5
update: After -> FinishWith
Mar 26, 2020
4e0d17f
update: FinishWith -> Finally
Mar 26, 2020
28c31d9
refactor: After -> Finally in tests
Mar 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed: unnecessary variable in Extend
  • Loading branch information
Mohammad Oweis committed Mar 25, 2020
commit af47edeb703cfcfe80e25dda2e8e42e3e60907e8
3 changes: 1 addition & 2 deletions chain.go
View file
Original file line number Diff line number Diff line change
@@ -125,10 +125,9 @@ func (c Chain) Append(constructors ...Constructor) Chain {
// // requests to aHtml hitting nosurfs failure handler go:
// m1 -> nosurf -> m2 -> csrfFail -> e1
func (c Chain) Extend(chain Chain) Chain {
newC := c.
return c.
Append(chain.constructors...).
AppendEndware(chain.endwares...)
return newC
}

// Endware is functionality executed after a the main handler is called