🌈 TEST 💩 PR 🚀 😎 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: `M.filename_line_to_diff_line` and `M.diff_line_to_filename_line` get out of sync. Solution: Drop them.
Owner
Author
|
hey |
justinmk
commented
Sep 23, 2025
| { desc = 'Request PR changes', noremap = true, silent = true, callback = pr_commands.request_changes_pr } | ||
| ) | ||
| end | ||
| utils.buf_keymap(buf, 'n', config.s.keymaps.diff.open_file, 'Open file', open_file_from_diff('edit')) |
Owner
Author
There was a problem hiding this comment.
test comment line 101 diff.lua
justinmk
commented
Oct 8, 2025
Comment on lines
+47
to
+51
| -- XXX fucking hack because Vim creates new buffer after (re)naming it. | ||
| bufs[feat][tostring(prnum)] = buf | ||
| return buf | ||
| -- end | ||
| end |
Owner
Author
There was a problem hiding this comment.
test comment state.lua lines 47-51
wefa
ewf
awe
fa
wef
code sample:
print('')
justinmk
commented
Oct 12, 2025
| { desc = 'Request PR changes', noremap = true, silent = true, callback = pr_commands.request_changes_pr } | ||
| ) | ||
| end | ||
| utils.buf_keymap(buf, 'n', config.s.keymaps.diff.open_file, 'Open file', open_file_from_diff('edit')) |
Owner
Author
There was a problem hiding this comment.
test diff.lua line 101
Owner
Author
There was a problem hiding this comment.
another comment on diff.lua line 101
justinmk
commented
Oct 13, 2025
|
|
||
| vim.bo[buf].buftype = 'nofile' | ||
| vim.bo[buf].readonly = false | ||
| vim.bo[buf].modifiable = true |
justinmk
commented
Oct 13, 2025
| buf, | ||
| 'PR Diff: ' .. selected_pr.number .. ' (' .. os.date('%Y-%m-%d %H:%M:%S') .. ')' | ||
| ) | ||
| buf = state.try_set_buf_name(buf, 'diff', selected_pr.number) |
justinmk
commented
Oct 13, 2025
Comment on lines
+119
to
+120
| M.buf_keymap(buf, 'n', key_binding, '', capture_input_and_close) | ||
| M.buf_keymap(buf, 'i', key_binding, '', capture_input_and_close) |
justinmk
commented
Oct 13, 2025
| { desc = 'View the PR diff', noremap = true, silent = true } | ||
| ) | ||
| end | ||
| utils.buf_keymap(buf, 'n', config.s.keymaps.pr.approve, 'Approve PR', M.approve_pr) |
Owner
Author
There was a problem hiding this comment.
test comment around line 200 in pr_commands.lua
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.