Uses master post and URL to set @url and @name. #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I've been using your
amp-jekyll
plugin on a blog, but I've had a problem when using it with thejekyll-sitemap
plugin. The AMP files were added to the sitemap, but the.html
extension for the generated AMP posts was excluded, meaning the sitemap links where broken. This is because thejekyll-sitemap
plugin usesJekyll::Page#url
to output the<loc>
of each post in the generated sitemap, andamp-jekyll
overrides@url
withdir
, which doesn't include the extension.I've made this change, which uses the
Jekyll::URL
class to set@url
in theJekyll::AmpPage
constructor. This fixes my problem above. I don't know whether this negatively impacts things elsewhere though... :SDoes this work as a general enhancement to
amp-jekyll
? I can tidy up the changes, such as constructor args if it does.