Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added #int reader #101

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

added #int reader #101

wants to merge 14 commits into from

Conversation

source-c
Copy link
Contributor

@source-c source-c commented Nov 5, 2021

for native Java services there are a lot of cases when numeric have to be strictly passed as integer. to avoid manual handling such needs #int reader to be added.

source-c and others added 12 commits October 21, 2016 14:42
- for lein and jars behaves same
- able to handle mixed includes
fix sample code in documentation
for native Java services there are a lot of cases when numeric have to be strictly passed as integer. 
to avoid manual handling such needs #int reader to be added.
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2021

Codecov Report

Merging #101 (e13104b) into master (743e9bc) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   79.13%   79.24%   +0.11%     
==========================================
  Files           4        4              
  Lines         369      371       +2     
  Branches       17       17              
==========================================
+ Hits          292      294       +2     
  Misses         60       60              
  Partials       17       17              
Impacted Files Coverage Δ
src/aero/core.cljc 74.68% <100.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 743e9bc...e13104b. Read the comment docs.

@olymk2
Copy link

olymk2 commented Dec 13, 2021

Any chance this can be merged ? just hit this myself configuring a db pool

DB_POOL_MAX_SIZE is read as a string but not accepted by https://github.com/brettwooldridge/HikariCP

:pool-opts {:maximumPoolSize #or [#env "DB_POOL_MAX_SIZE" 3]}

@source-c
Copy link
Contributor Author

Hello. Is there a chance the request become merged?

@source-c
Copy link
Contributor Author

source-c commented Sep 20, 2022

Any chance this can be merged ? just hit this myself configuring a db pool

DB_POOL_MAX_SIZE is read as a string but not accepted by https://github.com/brettwooldridge/HikariCP

:pool-opts {:maximumPoolSize #or [#env "DB_POOL_MAX_SIZE" 3]}

You are welcome to use https://github.com/dkdhub/edn-config instead. It is a drop-in replacement with #int reader enabled out-of-the-box.

@joelittlejohn
Copy link
Contributor

Seems fine to add an #int reader as we have #long and #double.

I don't like, however, that this allows two different ways to specify the int value in the edn: as an int or a string. This is a surefire way to make config inconsistent, with different styles used in different places, and engineers not being sure how they're supposed to specify values. Every other value is specified as a string, so we should stick with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants