-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added #int reader #101
base: master
Are you sure you want to change the base?
added #int reader #101
Conversation
- for lein and jars behaves same - able to handle mixed includes
upstream->fork
update from upstream
fix sample code in documentation
update repo
for native Java services there are a lot of cases when numeric have to be strictly passed as integer. to avoid manual handling such needs #int reader to be added.
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 79.13% 79.24% +0.11%
==========================================
Files 4 4
Lines 369 371 +2
Branches 17 17
==========================================
+ Hits 292 294 +2
Misses 60 60
Partials 17 17
Continue to review full report at Codecov.
|
Any chance this can be merged ? just hit this myself configuring a db pool DB_POOL_MAX_SIZE is read as a string but not accepted by https://github.com/brettwooldridge/HikariCP
|
Hello. Is there a chance the request become merged? |
You are welcome to use https://github.com/dkdhub/edn-config instead. It is a drop-in replacement with |
Seems fine to add an #int reader as we have #long and #double. I don't like, however, that this allows two different ways to specify the int value in the edn: as an int or a string. This is a surefire way to make config inconsistent, with different styles used in different places, and engineers not being sure how they're supposed to specify values. Every other value is specified as a string, so we should stick with that. |
for native Java services there are a lot of cases when numeric have to be strictly passed as integer. to avoid manual handling such needs #int reader to be added.