feat: add response_format json_object support#123
Open
lukasBlckIT wants to merge 2 commits intojwadow:mainfrom
Open
feat: add response_format json_object support#123lukasBlckIT wants to merge 2 commits intojwadow:mainfrom
lukasBlckIT wants to merge 2 commits intojwadow:mainfrom
Conversation
|
Thanks for the PR! 🎉 Before merge, we need a one-time CLA confirmation. Full CLA text: Please reply once with: You need to write once, all further messages from me can be ignored. |
|
Thanks for the PR! 🎉 Before merge, we need a one-time CLA confirmation. Full CLA text: Please reply once with: You need to write once, all further messages from me can be ignored. |
Author
|
I have read the CLA and I accept its terms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
response_format: {"type": "json_object"}is set, kiro-gateway accepts the parameter but does not forward it to the Kiro API. Claude responds with markdown-wrapped JSON (json ...) instead of raw JSON, causing JSON parsing failures in downstream clients (e.g. ValidationError in Honcho).Solution
Two-layer fix:
System prompt injection (
kiro/converters_openai.py) — whenresponse_format: json_objectis detected, appends a JSON instruction to the system prompt telling Claude to respond with raw JSON only, no markdown wrappers.Markdown stripping (
kiro/routes_openai.py+ newkiro/json_response_format.py) — post-processes non-streaming responses to strip any remaining markdown code block wrappers as a fallback.Behaviour
response_format: json_object→ raw, parseable JSON guaranteedresponse_format: textor noresponse_format→ completely unaffectedTesting
25/25 test cases passed locally, covering non-streaming, streaming, Swedish unicode characters, tool calling, auth errors, and edge cases.