Skip to content

Commit

Permalink
[LLDB][NFC]Renaming functions to be consistent with LLDB naming style (
Browse files Browse the repository at this point in the history
  • Loading branch information
oontvoo authored Feb 25, 2025
1 parent 724b91b commit 62ec7b8
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions lldb/include/lldb/Core/Telemetry.h
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,12 @@ class TelemetryManager : public llvm::telemetry::Manager {
llvm::Error preDispatch(llvm::telemetry::TelemetryInfo *entry) override;

virtual llvm::StringRef GetInstanceName() const = 0;
static TelemetryManager *getInstance();
static TelemetryManager *GetInstance();

protected:
TelemetryManager(std::unique_ptr<llvm::telemetry::Config> config);

static void setInstance(std::unique_ptr<TelemetryManager> manger);
static void SetInstance(std::unique_ptr<TelemetryManager> manger);

private:
std::unique_ptr<llvm::telemetry::Config> m_config;
Expand Down
4 changes: 2 additions & 2 deletions lldb/source/Core/Telemetry.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ llvm::Error TelemetryManager::preDispatch(TelemetryInfo *entry) {
}

std::unique_ptr<TelemetryManager> TelemetryManager::g_instance = nullptr;
TelemetryManager *TelemetryManager::getInstance() { return g_instance.get(); }
TelemetryManager *TelemetryManager::GetInstance() { return g_instance.get(); }

void TelemetryManager::setInstance(std::unique_ptr<TelemetryManager> manager) {
void TelemetryManager::SetInstance(std::unique_ptr<TelemetryManager> manager) {
g_instance = std::move(manager);
}

Expand Down
6 changes: 3 additions & 3 deletions lldb/unittests/Core/TelemetryTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ class FakePlugin : public telemetry::TelemetryManager {
}

static void Initialize() {
telemetry::TelemetryManager::setInstance(std::make_unique<FakePlugin>());
telemetry::TelemetryManager::SetInstance(std::make_unique<FakePlugin>());
}

static void Terminate() { telemetry::TelemetryManager::setInstance(nullptr); }
static void Terminate() { telemetry::TelemetryManager::SetInstance(nullptr); }
};

} // namespace lldb_private
Expand All @@ -76,7 +76,7 @@ TEST(TelemetryTest, PluginTest) {
// For tests, we just call it directly.
lldb_private::FakePlugin::Initialize();

auto *ins = lldb_private::telemetry::TelemetryManager::getInstance();
auto *ins = lldb_private::telemetry::TelemetryManager::GetInstance();
ASSERT_NE(ins, nullptr);

std::vector<const ::llvm::telemetry::TelemetryInfo *> expected_entries;
Expand Down

0 comments on commit 62ec7b8

Please sign in to comment.