DetectTOC: only go for lines containing '...' words #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DetectTOC will work on all lines, shaving off numbers from the last of the words in a given line, so long as the word is not all full-stops. This implies that a TOC line is one that contains strings containing only full-stops, and so, DetectTOC should only work on such lines. This change will remove unwanted behaviour where DetectTOC removes trailing numbers that we actually want to keep in lines, eg: Case Number : ABC 12/1234
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DetectTOC will work on all lines, shaving off numbers from the last of
the words in a given line, so long as the word is not all full-stops.
This implies that a TOC line is one that contains strings containing
only full-stops, and so, DetectTOC should only work on such lines.
This change will remove unwanted behaviour where DetectTOC removes
trailing numbers that we actually want to keep in lines, eg:
This PR is a backport of opengovsg#33