Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port controller should consider port status for Available condition #198

Closed
mdbooth opened this issue Jan 29, 2025 · 0 comments · Fixed by #222
Closed

Port controller should consider port status for Available condition #198

mdbooth opened this issue Jan 29, 2025 · 0 comments · Fixed by #222
Milestone
Release 2.0

Comments

@mdbooth
Copy link
Contributor

mdbooth commented Jan 29, 2025

The port controller reports a port as available as soon as it exists. However, Port has a status which should probably be the source of availability.
mandre added a commit to shiftstack/openstack-resource-controller that referenced this issue Feb 4, 2025
@mandre
Port: Make port available only when reported as active
24ebebd 
Ports reports their statuses via a status field, we should take that
into consideration when computing if the port is available or not.

With this change, ports are reported as Available when the object has
a known ID for the resource, and the resource has ACTIVE status.

Fixes k-orc#198
@mandre mandre mentioned this issue Feb 4, 2025
Merged
mandre added a commit to shiftstack/openstack-resource-controller that referenced this issue Feb 4, 2025
@mandre
Port: Make port available based on its status
b5de664 
Ports reports their statuses via a status field, we should take that
into consideration when computing if the port is available or not.

With this change, ports are reported as Available when the object has
a known ID for the resource, and the resource has ACTIVE or DOWN status.

Fixes k-orc#198
@mandre mandre added this to the Release 2.0 milestone Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.0
Development

Successfully merging a pull request may close this issue.

Port: Make port available based on its status shiftstack/openstack-resource-controller
2 participants
@mandre @mdbooth