Add a credentialsDependency to all controllers #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdbooth
force-pushed
the
secret-dependencies
branch
5 times, most recently
from
0c97374 to
097363c
Compare
github-actions
bot
added
semver:patch
With this change, all controllers will: * Add a finalizer to any credentials secret they reference * Wait gracefully for the creation of credentials which have not been created yet
This is required to add finalizers to secrets. If there is ever a way to do this with fewer privileges we should do that instead.
mdbooth
force-pushed
the
secret-dependencies
branch
from
097363c to
a2d5ce9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, all controllers will:
created yet
Merge first: