Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use shared k0s build workflow in nighty network conformance runs #5466

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use shared k0s build workflow in nighty network conformance runs #5466

wants to merge 1 commit into from
+16 −60

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jan 22, 2025

Description

This reduces quite some duplicate logic. Remove the ability to test a specific pull request, to keep things simple. It hasn't been used in a long time. This way, it doesn't have to be integrated into the shared build workflow, and it's still possible to run the whole workflow on a different branch (though this has to be a branch in the k0s repo, it can't live on a fork). Also, the network conformance tests are now part of the standard integration test suite anyway.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 marked this pull request as ready for review January 22, 2025 18:57
@twz123 twz123 requested review from a team as code owners January 22, 2025 18:57
@twz123 twz123 requested review from kke and jnummelin January 22, 2025 18:57
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

@twz123
Use shared k0s build workflow in nighty network conformance runs
726e878 
This reduces quite some duplicate logic. Remove the ability to test a
specific pull request, to keep things simple. It hasn't been used in a
long time. This way, it doesn't have to be integrated into the shared
build workflow, and it's still possible to run the whole workflow on
a different branch (though this has to be a branch in the k0s repo, it
can't live on a fork). Also, the network conformance tests are now part
of the standard integration test suite anyway.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 force-pushed the check-network-reuse-build-workflow branch from 8677623 to 726e878 Compare January 24, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kke kke Awaiting requested review from kke kke is a code owner automatically assigned from k0sproject/k0s-maintainers

@jnummelin jnummelin Awaiting requested review from jnummelin jnummelin is a code owner automatically assigned from k0sproject/k0s-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/ci chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@twz123