Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions cache optimizations #5467

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jan 22, 2025

Description

When a pull request is closed, clean up up the GitHub Actions caches associated with it.

Optimize Go's mod cache usage across GH Actions. In order to be able to share caches between operating systems, you have
to set enableCrossOsArchive to true, and the cache paths have to be identical (which was already the case). Also make sure that go.mod/go.sum files always use LF line endings, even on Windows. Otherwise the cache keys would be different.

See: https://github.com/actions/cache/blob/v4.2.0/tips-and-workarounds.md#cross-os-cache

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

In order to be able to share caches between operating systems, you have
to set enableCrossOsArchive to true, and the cache paths have to be
identical (which was already the case).

Also make sure that go.mod/go.sum files always use LF line endings, even
on Windows. Otherwise the cache keys would be different.

See: https://github.com/actions/cache/blob/v4.2.0/tips-and-workarounds.md#cross-os-cache
Signed-off-by: Tom Wieczorek <[email protected]>
Currently, it only cleans up the GitHub Actions caches associated with
the closed pull request.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 marked this pull request as ready for review January 22, 2025 18:56
@twz123 twz123 requested review from a team as code owners January 22, 2025 18:56
@twz123 twz123 requested review from ncopa and makhov January 22, 2025 18:56
@twz123 twz123 enabled auto-merge January 31, 2025 10:30
@twz123 twz123 merged commit 17781c6 into k0sproject:main Feb 6, 2025
92 checks passed
@twz123 twz123 deleted the actions-cache-optimizations branch February 6, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants