Validate removed apis #5476
Open
Validate removed apis #5476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we only support 1.29 - 1.32. In this scneario, there is no point keeping APIs older than 1.29. Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <[email protected]>
twz123
reviewed
Jan 24, 2025
pkg/autopilot/checks/checks.go
Outdated
|
|
||
| "github.com/k0sproject/k0s/pkg/kubernetes" | ||
|
|
||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/runtime/schema" | ||
| "k8s.io/client-go/metadata" | ||
| "k8s.io/cri-api/pkg/errors" |
There was a problem hiding this comment.
That looks like the wrong import.
There was a problem hiding this comment.
Good catch, fixed.
Prior implementation checked that there were no objects present in the removed APIs, however, it failed if the object was available on both the removed API and the present API. This behavior is incorrect and now for each object present in the removed API, we verify it's present in the new version (if available). Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <[email protected]>
juanluisvaladas
force-pushed
the
validate-removed-apis
branch
from
66a742e to
3347f86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior implementation checked that there were no objects present in the removed APIs, however, it failed if the object was available on both the removed API and the present API. This behavior is incorrect and now for each object present in the removed API, we verify it's present in the new version (if available).
This was tested on both 1.31 and 1.32
Type of change
How Has This Been Tested?
Checklist: