-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plumbing to optionally build for arm64 #266
Conversation
Signed-off-by: Nick Rogers <[email protected]>
Hi @courtland. Thanks for your PR. I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
Hey @courtland, thanks for submitting this. The dockerized tests have failed. Would you please check it? |
It looks like the I will raise another issue to fix the tests and then perhaps I can rebase this PR. |
/retest |
1 similar comment
/retest |
/lgtm Failed e2e on an unrelated flake |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: courtland, phoracek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Adds the ability to optionally build binaries for arm64 by setting
GOARCH
via Makefile variable overrides.For example:
Also fixes the non-dockerized
install-go
script to correctly download/install the versioned golang under an arm64 host.Combined, this permits building the plugin(s) for arm64 and/or x86 on either type of host.
Special notes for your reviewer:
Related to #260
Release note: