Add EP template and first EP #4
Conversation
This commit adds the enhancement proposal directory structure and template. It also adds a sample enhancement proposal for API unification
|
|
||
| ```yaml | ||
| e810: | ||
| internalDelays: |
There was a problem hiding this comment.
Prefer spaces over tabs for yaml indentation
josephdrichard
force-pushed
the
master
branch
2 times, most recently
from
6cf3a30 to
ab4968d
Compare
| COPY bindata /bindata | ||
|
|
||
| LABEL io.k8s.display-name="OpenShift ptp-operator" \ | ||
| io.k8s.description="This is a component that manages cluster PTP configuration." \ | ||
| io.openshift.tags="openshift,ptp" \ | ||
| com.redhat.delivery.appregistry=true \ | ||
| maintainer="PTP Dev Team <ptp[email protected]>" | ||
| maintainer="Multus Team <multus[email protected]>" |
There was a problem hiding this comment.
should be
maintainer="PTP Dev Team [email protected]"
| @@ -1,12 +1,12 @@ | |||
| FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.22-openshift-4.18 AS builder | |||
There was a problem hiding this comment.
I am not sure if we are running ci using rhel images or now . Any comment on this ? Do we have CI integrated for upstream now
|
|
||
| ENTRYPOINT ["/usr/local/bin/ptp-operator"] | ||
| ENTRYPOINT ["/usr/local/bin/ptp-operator"] |
| @@ -9,7 +9,7 @@ reviewers: | |||
| - SchSeba | |||
| - fedepaol | |||
| - oribon | |||
| - josephdrichard | |||
| - k8snetworkplumbingwg | |||
| - aneeshkp | |||
| - nishant-parekh | |||
There was a problem hiding this comment.
we can remove everyone that are not valid here
| @@ -9,7 +9,7 @@ reviewers: | |||
| - SchSeba | |||
| - fedepaol | |||
| - oribon | |||
| - josephdrichard | |||
| - k8snetworkplumbingwg | |||
There was a problem hiding this comment.
also why joseph removed?
| @@ -24,7 +24,7 @@ approvers: | |||
| - SchSeba | |||
| - fedepaol | |||
| - oribon | |||
| - josephdrichard | |||
| - k8snetworkplumbingwg | |||
There was a problem hiding this comment.
also why joseph removed?
| @@ -1,12 +1,12 @@ | |||
| FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.22-openshift-4.18 AS builder | |||
| WORKDIR /go/src/github.com/openshift/ptp-operator | |||
| WORKDIR /go/src/github.com/k8snetworkplumbingwg/ptp-operator | |||
There was a problem hiding this comment.
o we need ocp dockerfile upstream ?
| @@ -0,0 +1,30 @@ | |||
| # Regression testing | |||
| Regressions will be run periodically by QE, in order to ensure that everything is functional. This should be done before every release, including new builds of previous releases. Nothing should be delivered to customers that QE hasn't run a regression on and signed off on. | |||
There was a problem hiding this comment.
Who is upstream QE here ? our upstream CI should be configured to run regression ., I don't think QE will be running any regression on upstream
This commit adds the enhancement proposal directory structure and template. It also adds a sample enhancement proposal for API unification
/cc @josephdrichard @aneeshkp