-
Notifications
You must be signed in to change notification settings - Fork 0
Add support for MySQL 8 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
skuenzli
wants to merge
57
commits into
main
Choose a base branch
from
support-mysql8
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e required DB-specific syntax
* adjust epoch time in millis expression to be compatible with a default value for a MySQL BIGINT column * DRY-out expression def
…ing the system on MySQL.
Update system schema to work with MySQL. Create system schema during load of SystemDatabase because I could not determine the 'right' place to do it. Port upsert-style statements to MySQL compatible versions. In particular: * switch to MySQL on_duplicate_key_update from on_conflict_do_update * replace use of .returning with a separate select because MySQL does not support RETURNING. Still.
…ySQL does not distinguish between schemas and databases.
… have LISTEN/NOTIFY support
Was querying the whole table and returning the firs trow
https://dev.mysql.com/doc/refman/8.4/en/insert-on-duplicate.html > With ON DUPLICATE KEY UPDATE, the affected-rows value per row is 1 if the row is inserted as a new row, 2 if an existing row is updated, and 0 if an existing row is set to its current values.
…flow, and test_sleep to test_mysql
…SQL. However, it doesn't work in a proper non-blocking manner because MySQL lacks a pub/sub impl.
…, and exceptions works on MySQL. MySQL TEXT column supports a maximum length of 65,535 (216 − 1) characters. Less with multibyte characters. https://dev.mysql.com/doc/refman/8.4/en/string-type-syntax.html
* Convert SystemSchema to an interface, of sorts * Create function that defines the MySQL system schema and configures the SystemSchema object members appropriately
* Convert ApplicationSchema to an interface, of sorts * Create function that defines the MySQL application schema and configures the ApplicationSchema object members appropriately
…r-mysql Externalize db schema name for mysql
…abase/schema name is configurable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.