Fall back to using PP safe/final block if latest is not there #2266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using jj-spr 1.3.6-beta.1
Created using jj-spr 1.3.6-beta.1
larskuhtz
approved these changes
Oct 20, 2025
Comment on lines
+184
to
+186
| -- In this case we can only guess where a common fork point might be -- | ||
| -- in the worst case this is genesis. The more common case is 2. in | ||
| -- which case the "safe" block is probably known. |
There was a problem hiding this comment.
Suggested change
| -- In this case we can only guess where a common fork point might be -- | |
| -- in the worst case this is genesis. The more common case is 2. in | |
| -- which case the "safe" block is probably known. | |
| -- In this case we can only guess where a common fork point might be -- | |
| -- in the worst case this is the final block. The more common case is 2. in | |
| -- which case the "safe" block is probably known. Only in exceptional case | |
| -- this would be Genesis. |
There was a problem hiding this comment.
The worst case is still genesis though. One might say the second-worst case is the block above genesis, etc.
edmundnoble
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan: mainnet node deployment for 2 days.