Skip to content

remove service date #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove service date #2273

wants to merge 1 commit into from

Conversation

@chessai
Copy link
Contributor

@chessai chessai commented Oct 21, 2025

No description provided.

edmundnoble
edmundnoble previously approved these changes Oct 21, 2025
View reviewed changes
@chessai chessai force-pushed the chessai/remove-service-date branch from 12b2d75 to 5bb7af7 Compare October 21, 2025 20:05
jmcardon
jmcardon previously approved these changes Oct 21, 2025
View reviewed changes
@chessai chessai force-pushed the chessai/remove-service-date branch from 5bb7af7 to e24959c Compare October 21, 2025 21:22
@chessai chessai enabled auto-merge October 21, 2025 22:30
@larskuhtz
Copy link
Contributor

I propose that we hold merging (or at least releasing) this until #2272 is merged, too.

It would be difficult to introduce #2272 without a coordinated fork.

larskuhtz
larskuhtz requested changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@larskuhtz larskuhtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I approve the change, I propose that we don't merge that just yet.

If we decide to move ahead with #2272, we should make sure that we release and roll out both changes at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larskuhtz larskuhtz larskuhtz requested changes

@edmundnoble edmundnoble edmundnoble left review comments

@jmcardon jmcardon jmcardon left review comments

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chessai @larskuhtz @edmundnoble @jmcardon