This repository was archived by the owner on Jan 9, 2026. It is now read-only.
Conversation
larskuhtz
requested review from
emilypi,
jwiegley and
sirlensalot
as code owners
jwiegley
reviewed
Apr 19, 2023
jwiegley
approved these changes
Apr 19, 2023
Contributor
jwiegley
left a comment
jwiegley
left a comment
There was a problem hiding this comment.
These all seem like harmless changes, if it passes CI then I approve.
edmundnoble
approved these changes
Apr 19, 2023
jmcardon
approved these changes
Apr 19, 2023
Member
jmcardon
left a comment
jmcardon
left a comment
There was a problem hiding this comment.
Approved but also prefer traverse over mapM
Co-authored-by: Edmund Noble <edmundnoble@users.noreply.github.com>
Contributor
|
|
jwiegley
pushed a commit
that referenced
this pull request
Apr 26, 2023
* some linting * Update src/Pact/Compile.hs Co-authored-by: Edmund Noble <edmundnoble@users.noreply.github.com> --------- Co-authored-by: Edmund Noble <edmundnoble@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.