Skip to content
This repository was archived by the owner on Jan 9, 2026. It is now read-only.

applications.yaml workflow updates#1382

Merged
DevopsGoth merged 3 commits intomasterfrom
devops/workflow_updates
Feb 22, 2025
Merged

applications.yaml workflow updates#1382
DevopsGoth merged 3 commits intomasterfrom
devops/workflow_updates

Conversation

@DevopsGoth
Copy link
Contributor

@DevopsGoth DevopsGoth commented Feb 11, 2025

  • Remove possible vuln with pull_request_target (investigating this)
  • remove ubuntu-20.04 refs (those runners are end of life)
  • shuffled where aws secrets are used to ensure they are only there for steps that need them

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • New builtins have a FV translation
  • Documentation has been (manually) updated at https://docs.kadena.io/pact
  • Any changes that could be relevant to users have been recorded in the changelog
  • In case of changes to the Pact trace output (pact -t), make sure pact-lsp is in sync.

Additionally, please justify why you should or should not do the following:

  • Confirm replay/back compat
  • Benchmark regressions
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact

also shuffled where aws secrets are used to ensure they are only there for steps that need them
@DevopsGoth
Copy link
Contributor Author

I want to test the underlying workflow before this is merged

@DevopsGoth DevopsGoth marked this pull request as draft February 11, 2025 21:17
@DevopsGoth DevopsGoth changed the title Remove possible vuln, remove ubuntu-20.04 refs applications.yaml workflow updates Feb 11, 2025
@DevopsGoth DevopsGoth marked this pull request as ready for review February 12, 2025 01:24
@DevopsGoth
Copy link
Contributor Author

Per https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/

We should not be vulnerable just for using a pull_request_target trigger as we do not check out the PR head in this workflow. It was, however, not needed.

Ubuntu 20.04 runners will be turned off next month and thus have been removed from here, as they will be from all Kadena workflows over the next few weeks.

Copy link
Member

@rsoeldner rsoeldner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing Z3 should break some tests. I would just go ahead and suspend CI entirely for this repo. @emilypi what do you think?

Copy link
Contributor

@emilypi emilypi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a comment

@emilypi
Copy link
Contributor

emilypi commented Feb 12, 2025

@rsoeldner we'll archive this eventually, but i see no harm in keeping it alive until we get the go ahead.

@DevopsGoth DevopsGoth merged commit 69d6377 into master Feb 22, 2025
8 checks passed
@DevopsGoth DevopsGoth deleted the devops/workflow_updates branch February 25, 2025 07:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants