support return all result at once#10
Open
scc02 wants to merge 4 commits intokaelzhang:masterfrom
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 391 394 +3
=========================================
+ Hits 391 394 +3
Continue to review full report at Codecov.
|
Owner
|
我说中文吧,这两个问题在之前的 review 里面我有写 第一个是,我上面标记的,如果使用了 第二,是一个核心的问题,其实我们没有必要引入一个 option,只需要增加一个新的 event 类型,比如叫 |
Author
第一个已经修复 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这个变动的性质是
需求背景
实现方案和 API
对用户的影响和可能的风险