Skip to content

BE: Chore: remove unnecessary architecture check in unit test #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 13, 2025
Merged

BE: Chore: remove unnecessary architecture check in unit test #704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dc79429
refactor: remove unnecessary logic
yeikel Dec 12, 2024
f13b7ea
Update backend_tests.yml
yeikel Dec 16, 2024
77f618b
Update backend_tests.yml
yeikel Dec 16, 2024
7eceeac
Merge branch 'main' into refactor/remove-logic
yeikel Dec 23, 2024
e409256
Revert
yeikel Dec 23, 2024
c0bf9ab
bump test contaienrs
yeikel Dec 23, 2024
d7e266c
Merge branch 'main' into refactor/remove-logic
yeikel Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions api/src/test/java/io/kafbat/ui/AbstractIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,7 @@ public abstract class AbstractIntegrationTest {
public static final String LOCAL = "local";
public static final String SECOND_LOCAL = "secondLocal";

private static final boolean IS_ARM =
System.getProperty("os.arch").contains("arm") || System.getProperty("os.arch").contains("aarch64");

private static final String CONFLUENT_PLATFORM_VERSION = IS_ARM ? "7.8.0.arm64" : "7.8.0";
private static final String CONFLUENT_PLATFORM_VERSION = "7.8.0";

public static final KafkaContainer kafka = new KafkaContainer(
DockerImageName.parse("confluentinc/cp-kafka").withTag(CONFLUENT_PLATFORM_VERSION))
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<junit.version>5.11.2</junit.version>
<mockito.version>5.14.2</mockito.version>
<okhttp3.mockwebserver.version>4.12.0</okhttp3.mockwebserver.version>
<testcontainers.version>1.20.2</testcontainers.version>
<testcontainers.version>1.20.4</testcontainers.version>

<!-- Frontend dependency versions -->
<node.version>v18.17.1</node.version>
Expand Down
Loading