Skip to content

Conversation

@wernerdv
Copy link
Contributor

@wernerdv wernerdv commented Jan 11, 2025

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

  • Remove unused imports
  • Remove unused model/schemaregistry package

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@wernerdv wernerdv requested a review from a team as a code owner January 11, 2025 08:20
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jan 11, 2025
@wernerdv
Copy link
Contributor Author

@Haarolean PTAL

@Haarolean Haarolean added scope/backend Related to backend changes type/refactor Refactoring task and removed status/triage/manual Manual triage in progress labels Jan 14, 2025
@Haarolean Haarolean added this to the 1.2 milestone Jan 14, 2025
@Haarolean Haarolean merged commit 79e3910 into kafbat:main Jan 14, 2025
6 checks passed
@Haarolean
Copy link
Member

@wernerdv thanks!

@wernerdv wernerdv deleted the cleanup_model_package branch January 14, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope/backend Related to backend changes status/triage/completed Automatic triage completed type/refactor Refactoring task

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants