Skip to content

Conversation

@Haarolean
Copy link
Member

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Fixes #778

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean added scope/backend Related to backend changes type/bug Something isn't working area/auth App authentication related issues labels Jan 15, 2025
@Haarolean Haarolean self-assigned this Jan 15, 2025
@Haarolean Haarolean requested a review from a team as a code owner January 15, 2025 07:34
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jan 15, 2025
@Haarolean Haarolean added this to the 1.1.1 milestone Jan 15, 2025
@Haarolean Haarolean merged commit 6f89bfa into main Jan 15, 2025
37 of 39 checks passed
@Haarolean Haarolean deleted the issues/778 branch January 15, 2025 08:56
@Haarolean Haarolean modified the milestones: 1.1.1, 1.2 Mar 15, 2025
@Haarolean Haarolean moved this from Todo to Done in Release 1.2 Mar 15, 2025
@ghost
Copy link

ghost commented Mar 25, 2025

For the old and new version, I see login password when I inspect the web page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/auth App authentication related issues scope/backend Related to backend changes status/triage/completed Automatic triage completed type/bug Something isn't working

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

LDAP: An LdapAuthenticator must be supplied

2 participants