feat: add support for nodeSelector and tolerations #23
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: Sara Qasmi <[email protected]>
dimetron
requested review from
Copilot
and removed request for
EItanya and
dimetron
There was a problem hiding this comment.
Pull Request Overview
This PR adds Kubernetes pod scheduling support by introducing nodeSelector, tolerations, affinity, and topologySpreadConstraints configuration options to the Helm chart. This enables users to control where their pods are scheduled based on node characteristics and constraints.
- Added four new scheduling configuration options to values.yaml with appropriate defaults
- Updated deployment template to conditionally include these scheduling configurations
- Enhanced topologySpreadConstraints with automatic labelSelector injection when not provided
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| helm/kagent-tools/values.yaml | Adds new scheduling configuration fields with comments and example values |
| helm/kagent-tools/templates/deployment.yaml | Implements conditional rendering of scheduling configurations in the pod spec |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
@dimetron, this PR is making me realize that we need helm unit tests |
|
@EItanya I will add the unit tests |
2 participants
#22