-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add startech bangs #130
Add startech bangs #130
Conversation
Oh, I assumed I was able to use relative urls. Am I supposed to use full ones? |
Yes, the domain should be duplicated between |
One bang should be fine, we don't necessarily need a bang for each region |
It would be cool if there way a way to have country detection when usings bangs (so that for example if I, someone from Belgium, uses !startech, it goes to the belgian one). |
It's not been brought up but it is something I've thought about. Hard part is getting the region code formatted in the way the original site needs, and what happens if the site doesn't support that region? There could be some more complex logic w/ a hash for each bang, but things start to get complicated. Not against looking into it though. |
kagifeedback it is! xd (i'll make one in a sec). I'll close this PR and just add it to another then considering its only one thing |
Actually, bangs are free, no reason to not have the region specific bangs in the meantime. Feel free to add them to the latest PR. |
ah cool nice, one sec |
Adds a general and country specific bangs for the startech website
in case they're ever needed in the future, because If I delete the branch it'll go away: