Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add startech bangs #130

Closed
wants to merge 1 commit into from
Closed

Conversation

thibaultmol
Copy link
Contributor

@thibaultmol thibaultmol commented Oct 28, 2024

Adds a general and country specific bangs for the startech website

in case they're ever needed in the future, because If I delete the branch it'll go away:
{
  "s": "Startech United States",
  "d": "startech.com",
  "t": "startechus",
  "u": "/en-us/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech Canada",
  "d": "startech.com",
  "t": "startechca",
  "u": "/en-ca/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech United Kingdom",
  "d": "startech.com",
  "t": "startechuk",
  "u": "/en-gb/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech Republic of Ireland",
  "d": "startech.com",
  "t": "startechie",
  "u": "/en-ie/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech Europe",
  "d": "startech.com",
  "t": "startecheu",
  "u": "/en-eu/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech Australia",
  "d": "startech.com",
  "t": "startechau",
  "u": "/en-au/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech Austria",
  "d": "startech.com",
  "t": "startechat",
  "u": "/de-at/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech Belgium",
  "d": "startech.com",
  "t": "startechbe",
  "u": "/en-be/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech Chile",
  "d": "startech.com",
  "t": "startechcl",
  "u": "/es-cl/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech Colombia",
  "d": "startech.com",
  "t": "startechco",
  "u": "/es-co/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech Denmark",
  "d": "startech.com",
  "t": "startechdk",
  "u": "/en-dk/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech Finland",
  "d": "startech.com",
  "t": "startechfi",
  "u": "/en-fi/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech France",
  "d": "startech.com",
  "t": "startechfr",
  "u": "/fr-fr/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech Germany",
  "d": "startech.com",
  "t": "startechde",
  "u": "/de-de/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech Italy",
  "d": "startech.com",
  "t": "startechit",
  "u": "/it-it/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech Japan",
  "d": "startech.com",
  "t": "startechjp",
  "u": "/ja-jp/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech Mexico",
  "d": "startech.com",
  "t": "startechmx",
  "u": "/es-mx/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech Netherlands",
  "d": "startech.com",
  "t": "startechnl",
  "u": "/nl-nl/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech New Zealand",
  "d": "startech.com",
  "t": "startechnz",
  "u": "/en-nz/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech Peru",
  "d": "startech.com",
  "t": "startechpe",
  "u": "/es-pe/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech Singapore",
  "d": "startech.com",
  "t": "startechsg",
  "u": "/en-sg/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech Spain",
  "d": "startech.com",
  "t": "starteches",
  "u": "/es-es/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech Sweden",
  "d": "startech.com",
  "t": "startechse",
  "u": "/sv-se/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
},
{
  "s": "Startech Switzerland",
  "d": "startech.com",
  "t": "startechch",
  "u": "/de-ch/search?search_term={{{s}}}",
  "c": "Shopping",
  "sc": "Tech"
}  

@thibaultmol
Copy link
Contributor Author

Oh, I assumed I was able to use relative urls. Am I supposed to use full ones?

@nobodywasishere
Copy link
Member

Am I supposed to use full ones?

Yes, the domain should be duplicated between d and u

@nobodywasishere
Copy link
Member

One bang should be fine, we don't necessarily need a bang for each region

@thibaultmol
Copy link
Contributor Author

It would be cool if there way a way to have country detection when usings bangs (so that for example if I, someone from Belgium, uses !startech, it goes to the belgian one).
Has that ever been brought up?
obv it's not supported in the current bang schema I suppose, but just curious

@nobodywasishere
Copy link
Member

It's not been brought up but it is something I've thought about. Hard part is getting the region code formatted in the way the original site needs, and what happens if the site doesn't support that region? There could be some more complex logic w/ a hash for each bang, but things start to get complicated. Not against looking into it though.

@thibaultmol
Copy link
Contributor Author

kagifeedback it is! xd (i'll make one in a sec). I'll close this PR and just add it to another then considering its only one thing

@thibaultmol
Copy link
Contributor Author

@nobodywasishere
Copy link
Member

Actually, bangs are free, no reason to not have the region specific bangs in the meantime. Feel free to add them to the latest PR.

@thibaultmol
Copy link
Contributor Author

thibaultmol commented Oct 28, 2024

ah cool nice, one sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants