Skip to content

test: Refactor distributed job creation in testing#1482

Open
itsomri wants to merge 1 commit into
mainfrom
omric/unified-distributed-batch-job-helper
Open

test: Refactor distributed job creation in testing#1482
itsomri wants to merge 1 commit into
mainfrom
omric/unified-distributed-batch-job-helper

Conversation

@itsomri
Copy link
Copy Markdown
Collaborator

@itsomri itsomri commented Apr 27, 2026

Description

Our e2e tests relied on several different helper functions to simulate jobs, distributed jobs, elastic, kwok etc. With the introduction of fine-grained minMember annotation for batch jobs, all these helpers can be consolidated, simplifying tests and potentially improving test performance, as we offload distributed pod creation to the k8s job controller instead of the test client.

Checklist

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated documentation (if needed)

Breaking Changes

Additional Notes

Signed-off-by: itsomri <omric@nvidia.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 27, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c0d53d26-7514-408e-b2d9-1da23c6eb050

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch omric/unified-distributed-batch-job-helper

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/kai-scheduler/KAI-scheduler/test/e2e/modules/resources/rd 0.00% (ø)
github.com/kai-scheduler/KAI-scheduler/test/e2e/scale 0.00% (ø)
github.com/kai-scheduler/KAI-scheduler/test/e2e/suites/allocate/topology 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/kai-scheduler/KAI-scheduler/test/e2e/modules/resources/rd/distributed_batch_job.go 0.00% (ø) 0 0 0
github.com/kai-scheduler/KAI-scheduler/test/e2e/scale/kwok_job_creation.go 0.00% (ø) 0 0 0
github.com/kai-scheduler/KAI-scheduler/test/e2e/scale/kwok_test_utils.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/kai-scheduler/KAI-scheduler/test/e2e/suites/allocate/topology/topology_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant