fix(scheduler): Fix jumping solver potential victims usage by davidLif · Pull Request #1531 · kai-scheduler/KAI-Scheduler

davidLif · 2026-05-03T18:00:26Z

Description

1- Add unitest that requires a jumping solver to evict from multiple nodes to successfully simulate a reclaim
2- Remember how many new tasks have been added to the partial representation job in the solver. In case it is more then 1, evict all potential victims at once.
3- Fix "LatestPotentialVictims" implementation.

Related Issues

Fixes #1546

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

Self-reviewed
Added/updated tests (if needed)
Updated documentation (if needed)

Breaking Changes

Additional Notes

coderabbitai · 2026-05-03T18:00:32Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 841795fb-5a49-4fd3-8be3-a038c3934e7f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch DavidL/fixJumpSolverPotentialVictimUsage

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Signed-off-by: itsomri <omric@nvidia.com>

…ntation job in the solver. In case it is more then 1, evict all potential victims at once. 2- Fix "LatestPotentialVictims" implementation. Signed-off-by: davidLif <davidshani12@gmail.com>

github-actions · 2026-05-03T18:14:49Z

📊 Performance Benchmark Results

Comparing PR (DavidL/fixJumpSolverPotentialVictimUsage) vs main branch — click to expand

goos: linux
goarch: amd64
pkg: github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions
cpu: AMD EPYC 7763 64-Core Processor                
                                    │ main-bench.txt │           pr-bench.txt            │
                                    │     sec/op     │   sec/op     vs base              │
AllocateAction_SmallCluster-4            107.6m ± 0%   107.6m ± 0%       ~ (p=0.699 n=6)
AllocateAction_MediumCluster-4           134.4m ± 1%   130.5m ± 1%  -2.89% (p=0.002 n=6)
AllocateAction_LargeCluster-4            207.3m ± 1%   200.0m ± 3%  -3.49% (p=0.004 n=6)
ReclaimAction_SmallCluster-4             102.8m ± 0%   102.8m ± 0%       ~ (p=0.699 n=6)
ReclaimAction_MediumCluster-4            105.6m ± 1%   105.6m ± 0%       ~ (p=0.937 n=6)
PreemptAction_SmallCluster-4             103.3m ± 0%   103.2m ± 0%       ~ (p=0.818 n=6)
PreemptAction_MediumCluster-4            110.3m ± 1%   110.5m ± 1%       ~ (p=0.818 n=6)
ConsolidationAction_SmallCluster-4       124.0m ± 0%   123.5m ± 1%  -0.36% (p=0.041 n=6)
ConsolidationAction_MediumCluster-4      286.3m ± 1%   276.0m ± 1%  -3.61% (p=0.002 n=6)
FullSchedulingCycle_SmallCluster-4       105.0m ± 0%   104.9m ± 0%       ~ (p=0.310 n=6)
FullSchedulingCycle_MediumCluster-4      121.3m ± 2%   118.9m ± 1%  -2.01% (p=0.009 n=6)
FullSchedulingCycle_LargeCluster-4       158.6m ± 2%   156.0m ± 1%  -1.62% (p=0.041 n=6)
ManyQueues_MediumCluster-4               139.1m ± 2%   133.7m ± 2%  -3.85% (p=0.004 n=6)
GangScheduling_MediumCluster-4           156.7m ± 1%   151.4m ± 2%  -3.35% (p=0.002 n=6)
geomean                                  133.6m        131.6m       -1.52%

                                    │ main-bench.txt │            pr-bench.txt             │
                                    │      B/op      │     B/op       vs base              │
AllocateAction_SmallCluster-4           2.194Mi ± 1%    2.235Mi ± 1%  +1.89% (p=0.002 n=6)
AllocateAction_MediumCluster-4          11.96Mi ± 0%    11.70Mi ± 0%  -2.17% (p=0.002 n=6)
AllocateAction_LargeCluster-4           41.45Mi ± 0%    39.49Mi ± 0%  -4.72% (p=0.002 n=6)
ReclaimAction_SmallCluster-4            912.6Ki ± 1%    913.0Ki ± 0%       ~ (p=0.818 n=6)
ReclaimAction_MediumCluster-4           3.000Mi ± 0%    2.997Mi ± 0%       ~ (p=0.589 n=6)
PreemptAction_SmallCluster-4            1.041Mi ± 1%    1.043Mi ± 1%       ~ (p=0.132 n=6)
PreemptAction_MediumCluster-4           4.241Mi ± 0%    4.245Mi ± 0%       ~ (p=0.180 n=6)
ConsolidationAction_SmallCluster-4      9.934Mi ± 0%   10.020Mi ± 0%  +0.86% (p=0.002 n=6)
ConsolidationAction_MediumCluster-4     89.35Mi ± 0%    88.81Mi ± 0%  -0.60% (p=0.002 n=6)
FullSchedulingCycle_SmallCluster-4      1.406Mi ± 1%    1.432Mi ± 0%  +1.86% (p=0.002 n=6)
FullSchedulingCycle_MediumCluster-4     6.980Mi ± 0%    6.845Mi ± 0%  -1.94% (p=0.002 n=6)
FullSchedulingCycle_LargeCluster-4      22.99Mi ± 0%    21.99Mi ± 0%  -4.33% (p=0.002 n=6)
ManyQueues_MediumCluster-4              16.42Mi ± 0%    16.16Mi ± 0%  -1.57% (p=0.002 n=6)
GangScheduling_MediumCluster-4          17.24Mi ± 0%    16.72Mi ± 0%  -3.00% (p=0.002 n=6)
geomean                                 7.035Mi         6.966Mi       -0.98%

                                    │ main-bench.txt │           pr-bench.txt            │
                                    │   allocs/op    │  allocs/op   vs base              │
AllocateAction_SmallCluster-4            35.01k ± 0%   35.03k ± 0%  +0.08% (p=0.002 n=6)
AllocateAction_MediumCluster-4           312.8k ± 0%   299.8k ± 0%  -4.15% (p=0.002 n=6)
AllocateAction_LargeCluster-4            1.338M ± 0%   1.259M ± 0%  -5.89% (p=0.002 n=6)
ReclaimAction_SmallCluster-4             8.200k ± 0%   8.203k ± 0%       ~ (p=0.892 n=6)
ReclaimAction_MediumCluster-4            26.14k ± 0%   26.14k ± 0%       ~ (p=1.000 n=6)
PreemptAction_SmallCluster-4             11.04k ± 0%   11.04k ± 0%       ~ (p=0.584 n=6)
PreemptAction_MediumCluster-4            38.58k ± 0%   38.58k ± 0%       ~ (p=0.355 n=6)
ConsolidationAction_SmallCluster-4       129.8k ± 0%   129.8k ± 0%  +0.06% (p=0.002 n=6)
ConsolidationAction_MediumCluster-4      1.306M ± 0%   1.282M ± 0%  -1.82% (p=0.002 n=6)
FullSchedulingCycle_SmallCluster-4       20.67k ± 0%   20.68k ± 0%  +0.05% (p=0.039 n=6)
FullSchedulingCycle_MediumCluster-4      168.3k ± 0%   162.3k ± 0%  -3.57% (p=0.002 n=6)
FullSchedulingCycle_LargeCluster-4       698.6k ± 0%   660.6k ± 0%  -5.45% (p=0.002 n=6)
ManyQueues_MediumCluster-4               350.6k ± 0%   337.7k ± 0%  -3.70% (p=0.002 n=6)
GangScheduling_MediumCluster-4           571.8k ± 0%   545.9k ± 0%  -4.53% (p=0.002 n=6)
geomean                                  118.7k        116.2k       -2.09%

pkg: github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/integration_tests/reclaim
                            │ main-bench.txt │             pr-bench.txt             │
                            │     sec/op     │    sec/op     vs base                │
ReclaimLargeJobs_10Node-4        105.1m ± 0%    106.0m ± 1%    +0.85% (p=0.002 n=6)
ReclaimLargeJobs_50Node-4        227.2m ± 1%    316.7m ± 3%   +39.43% (p=0.002 n=6)
ReclaimLargeJobs_100Node-4       375.5m ± 1%    884.0m ± 6%  +135.39% (p=0.002 n=6)
ReclaimLargeJobs_200Node-4       744.5m ± 7%   2942.8m ± 1%  +295.27% (p=0.002 n=6)
ReclaimLargeJobs_500Node-4        2.344 ± 1%    15.653 ± 1%  +567.78% (p=0.002 n=6)
ReclaimLargeJobs_1000Node-4       6.906 ± 1%    65.626 ± 1%  +850.31% (p=0.002 n=6)
geomean                          690.1m          2.116       +206.57%

                            │ main-bench.txt │              pr-bench.txt               │
                            │      B/op      │      B/op       vs base                 │
ReclaimLargeJobs_10Node-4       2.013Mi ± 2%    2.379Mi ± 15%    +18.14% (p=0.002 n=6)
ReclaimLargeJobs_50Node-4       60.67Mi ± 0%    81.11Mi ±  4%    +33.69% (p=0.002 n=6)
ReclaimLargeJobs_100Node-4      121.4Mi ± 0%    283.4Mi ±  2%   +133.46% (p=0.002 n=6)
ReclaimLargeJobs_200Node-4      245.0Mi ± 0%   1077.9Mi ±  1%   +339.94% (p=0.002 n=6)
ReclaimLargeJobs_500Node-4      628.2Mi ± 0%   6485.1Mi ±  0%   +932.26% (p=0.002 n=6)
ReclaimLargeJobs_1000Node-4     1.281Gi ± 0%   27.049Gi ±  0%  +2011.19% (p=0.002 n=6)
geomean                         120.1Mi         468.6Mi         +290.30%

                            │ main-bench.txt │              pr-bench.txt               │
                            │   allocs/op    │   allocs/op     vs base                 │
ReclaimLargeJobs_10Node-4        22.21k ± 2%     27.11k ± 16%    +22.08% (p=0.002 n=6)
ReclaimLargeJobs_50Node-4        814.3k ± 0%    2225.8k ±  2%   +173.33% (p=0.002 n=6)
ReclaimLargeJobs_100Node-4       1.620M ± 0%     9.675M ±  1%   +497.32% (p=0.002 n=6)
ReclaimLargeJobs_200Node-4       3.229M ± 0%    43.241M ±  0%  +1239.04% (p=0.002 n=6)
ReclaimLargeJobs_500Node-4       8.081M ± 0%   301.858M ±  0%  +3635.35% (p=0.002 n=6)
ReclaimLargeJobs_1000Node-4      16.25M ± 0%   1370.16M ±  0%  +8334.31% (p=0.002 n=6)
geomean                          1.522M          14.78M         +871.52%

pkg: github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/reclaim
                            │ main-bench.txt │
                            │     sec/op     │
ReclaimWithMissingPVCJobs-4       12.86 ± 2%

                            │ main-bench.txt │
                            │      B/op      │
ReclaimWithMissingPVCJobs-4     4.115Gi ± 0%

                            │ main-bench.txt │
                            │   allocs/op    │
ReclaimWithMissingPVCJobs-4      20.97M ± 0%

Legend

📉 Negative delta = Performance improvement (faster)
📈 Positive delta = Performance regression (slower)
p-value < 0.05 indicates statistically significant change

Raw benchmark data

PR branch:

goos: linux
goarch: amd64
pkg: github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions
cpu: AMD EPYC 7763 64-Core Processor                
BenchmarkAllocateAction_SmallCluster-4         	      10	 107552544 ns/op	 2343504 B/op	   35028 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107464582 ns/op	 2354948 B/op	   35033 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107732708 ns/op	 2355483 B/op	   35037 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107732800 ns/op	 2342731 B/op	   35034 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107680128 ns/op	 2342835 B/op	   35034 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107355568 ns/op	 2343826 B/op	   35034 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 130312924 ns/op	12272165 B/op	  299789 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 130020239 ns/op	12270623 B/op	  299796 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 130424816 ns/op	12271035 B/op	  299809 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 130601252 ns/op	12269624 B/op	  299809 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 131863371 ns/op	12269963 B/op	  299769 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 132159775 ns/op	12269138 B/op	  299825 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       6	 201074498 ns/op	41431013 B/op	 1259328 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       6	 198178764 ns/op	41410142 B/op	 1259335 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       6	 197628745 ns/op	41414688 B/op	 1259377 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       6	 199001230 ns/op	41406057 B/op	 1259324 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       6	 201202333 ns/op	41405001 B/op	 1259372 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 205540406 ns/op	41405977 B/op	 1259317 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 103075564 ns/op	  932730 B/op	    8191 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102709260 ns/op	  937740 B/op	    8203 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102782896 ns/op	  934576 B/op	    8202 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102784604 ns/op	  934797 B/op	    8203 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102771498 ns/op	  938375 B/op	    8203 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102790484 ns/op	  935039 B/op	    8203 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105747151 ns/op	 3138753 B/op	   26145 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105549365 ns/op	 3146976 B/op	   26145 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105635202 ns/op	 3145952 B/op	   26146 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105539187 ns/op	 3142196 B/op	   26145 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105578122 ns/op	 3142223 B/op	   26145 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105463876 ns/op	 3142024 B/op	   26144 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103128973 ns/op	 1087320 B/op	   11040 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103154052 ns/op	 1095471 B/op	   11044 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103289073 ns/op	 1095676 B/op	   11045 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103274214 ns/op	 1091426 B/op	   11042 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103171607 ns/op	 1091536 B/op	   11043 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103412940 ns/op	 1095391 B/op	   11044 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 111301336 ns/op	 4446622 B/op	   38574 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 110405845 ns/op	 4457620 B/op	   38578 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 110709848 ns/op	 4451076 B/op	   38577 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 110506540 ns/op	 4450992 B/op	   38577 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 110108974 ns/op	 4451054 B/op	   38578 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 110022988 ns/op	 4446930 B/op	   38576 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 122785729 ns/op	10506632 B/op	  129819 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 123857420 ns/op	10520422 B/op	  129855 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 124195162 ns/op	10504716 B/op	  129832 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 123556840 ns/op	10505949 B/op	  129846 allocs/op

Main branch:

goos: linux
goarch: amd64
pkg: github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions
cpu: AMD EPYC 7763 64-Core Processor                
BenchmarkAllocateAction_SmallCluster-4         	      10	 107361639 ns/op	 2309848 B/op	   35015 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107490406 ns/op	 2299695 B/op	   35007 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107625072 ns/op	 2298807 B/op	   35005 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107563996 ns/op	 2314797 B/op	   35011 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107640786 ns/op	 2300892 B/op	   35006 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107651789 ns/op	 2298705 B/op	   35004 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 134015648 ns/op	12552294 B/op	  312789 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 133368030 ns/op	12545581 B/op	  312790 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 134373585 ns/op	12541835 B/op	  312780 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 134681891 ns/op	12542425 B/op	  312786 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 134423028 ns/op	12542081 B/op	  312783 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 134563067 ns/op	12542273 B/op	  312784 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 208282746 ns/op	43462427 B/op	 1338179 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 208101747 ns/op	43461081 B/op	 1338168 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 207728573 ns/op	43458761 B/op	 1338151 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 205343128 ns/op	43459460 B/op	 1338154 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 206798791 ns/op	43459972 B/op	 1338156 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 206734776 ns/op	43465480 B/op	 1338154 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102766801 ns/op	  930314 B/op	    8179 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102817609 ns/op	  929252 B/op	    8185 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102678159 ns/op	  934197 B/op	    8198 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102811262 ns/op	  938596 B/op	    8204 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102794944 ns/op	  938524 B/op	    8204 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102807825 ns/op	  934839 B/op	    8203 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 106252092 ns/op	 3146105 B/op	   26146 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105706262 ns/op	 3147460 B/op	   26146 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105227816 ns/op	 3145888 B/op	   26145 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105295065 ns/op	 3142199 B/op	   26145 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105629240 ns/op	 3145855 B/op	   26145 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105602782 ns/op	 3138148 B/op	   26142 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103426537 ns/op	 1087295 B/op	   11042 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103270997 ns/op	 1094837 B/op	   11043 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103317504 ns/op	 1083844 B/op	   11043 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103186735 ns/op	 1091207 B/op	   11043 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103249616 ns/op	 1095047 B/op	   11044 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103080127 ns/op	 1090904 B/op	   11041 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 110017834 ns/op	 4449313 B/op	   38577 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 109548771 ns/op	 4456044 B/op	   38578 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 111538952 ns/op	 4449158 B/op	   38576 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 111607178 ns/op	 4445592 B/op	   38576 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 109396214 ns/op	 4433463 B/op	   38570 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 110525504 ns/op	 4441456 B/op	   38574 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 123586194 ns/op	10417237 B/op	  129761 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 124442430 ns/op	10416609 B/op	  129768 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 124426294 ns/op	10412320 B/op	  129717 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 123884810 ns/op	10418757 B/op	  129776 allocs/op

github-actions · 2026-05-03T18:40:02Z

Merging this branch will increase overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers	19.54% (+0.55%)	👍
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers/scenario	67.00% (+1.41%)	👍
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/preempt	85.71% (ø)
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/reclaim	87.50% (ø)

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers/by_pod_solver.go	0.00% (ø)	126 (+4)	0	126 (+4)
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers/job_solver.go	0.00% (ø)	113	0	113
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers/pod_scenario_builder.go	93.65% (+0.32%)	63 (+3)	59 (+3)	4	👍
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers/scenario/base_scenario.go	57.69% (+2.14%)	78 (+6)	45 (+5)	33 (+1)	👍
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers/scenario/by_node_scenario.go	100.00% (ø)	22 (+1)	22 (+1)	0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers/scenario/base_scenario_test.go
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/preempt/preemptGang_test.go
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/reclaim/reclaim_test.go

Signed-off-by: davidLif <davidshani12@gmail.com>

github-actions · 2026-05-04T09:18:59Z

Merging this branch will increase overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers	19.54% (+0.55%)	👍
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers/scenario	67.00% (+1.41%)	👍
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/integration_tests/reclaim	0.00% (ø)
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/preempt	85.71% (ø)
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/reclaim	87.50% (ø)

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers/by_pod_solver.go	0.00% (ø)	126 (+4)	0	126 (+4)
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers/job_solver.go	0.00% (ø)	113	0	113
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers/pod_scenario_builder.go	93.65% (+0.32%)	63 (+3)	59 (+3)	4	👍
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers/scenario/base_scenario.go	57.69% (+2.14%)	78 (+6)	45 (+5)	33 (+1)	👍
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers/scenario/by_node_scenario.go	100.00% (ø)	22 (+1)	22 (+1)	0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers/scenario/base_scenario_test.go
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/integration_tests/reclaim/reclaim_benchmark_test.go
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/preempt/preemptGang_test.go
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/reclaim/reclaim_test.go

Signed-off-by: davidLif <davidshani12@gmail.com>

github-actions · 2026-05-05T09:50:43Z

Merging this branch changes the coverage (1 decrease, 2 increase)

Impacted Packages	Coverage Δ	🤖
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers	19.54% (+0.55%)	👍
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers/scenario	67.00% (+1.41%)	👍
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/integration_tests/reclaim	0.00% (ø)
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/preempt	85.71% (ø)
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/reclaim	87.50% (ø)
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/framework	35.45% (-0.56%)	👎

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers/by_pod_solver.go	0.00% (ø)	126 (+4)	0	126 (+4)
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers/job_solver.go	0.00% (ø)	113	0	113
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers/pod_scenario_builder.go	93.65% (+0.32%)	63 (+3)	59 (+3)	4	👍
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers/scenario/base_scenario.go	57.69% (+2.14%)	78 (+6)	45 (+5)	33 (+1)	👍
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers/scenario/by_node_scenario.go	100.00% (ø)	22 (+1)	22 (+1)	0
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/framework/session.go	0.50% (-0.03%)	200 (+13)	1	199 (+13)	👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/common/solvers/scenario/base_scenario_test.go
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/integration_tests/reclaim/reclaim_benchmark_test.go
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/preempt/preemptGang_test.go
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/reclaim/reclaim_test.go

itsomri and others added 2 commits May 3, 2026 21:03

Exponential solver regression test

434e2d0

Signed-off-by: itsomri <omric@nvidia.com>

1- Remember how many new tasks have been added to the partial represe…

6ceb2c5

…ntation job in the solver. In case it is more then 1, evict all potential victims at once. 2- Fix "LatestPotentialVictims" implementation. Signed-off-by: davidLif <davidshani12@gmail.com>

davidLif force-pushed the DavidL/fixJumpSolverPotentialVictimUsage branch from ecd61ed to 6ceb2c5 Compare May 3, 2026 18:03

Fix hero job benchmark run

c7966a2

Signed-off-by: davidLif <davidshani12@gmail.com>

davidLif added 2 commits May 5, 2026 12:10

Test OrderedNodesByTask parallel run improvement

eea2b8d

Signed-off-by: davidLif <davidshani12@gmail.com>

s1

7b31e41

Signed-off-by: davidLif <davidshani12@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(scheduler): Fix jumping solver potential victims usage#1531

fix(scheduler): Fix jumping solver potential victims usage#1531
davidLif wants to merge 5 commits into
mainfrom
DavidL/fixJumpSolverPotentialVictimUsage

davidLif commented May 3, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 3, 2026 •

edited

Loading

Review skipped

Uh oh!

github-actions Bot commented May 3, 2026 •

edited

Loading

Legend

Uh oh!

github-actions Bot commented May 3, 2026

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions Bot commented May 4, 2026

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions Bot commented May 5, 2026

Changed files (no unit tests)

Changed unit test files

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

davidLif commented May 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Checklist

Breaking Changes

Additional Notes

Uh oh!

coderabbitai Bot commented May 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions Bot commented May 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Performance Benchmark Results

Legend

Uh oh!

github-actions Bot commented May 3, 2026

Merging this branch will increase overall coverage

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions Bot commented May 4, 2026

Merging this branch will increase overall coverage

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions Bot commented May 5, 2026

Merging this branch changes the coverage (1 decrease, 2 increase)

Changed files (no unit tests)

Changed unit test files

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

davidLif commented May 3, 2026 •

edited

Loading

coderabbitai Bot commented May 3, 2026 •

edited

Loading

github-actions Bot commented May 3, 2026 •

edited

Loading