Skip to content

feat(scheduler): Improve OrderedNodesByTask parallelization#1548

Open
davidLif wants to merge 4 commits into
mainfrom
DavidL/1546/improveOrderedNodesByTask
Open

feat(scheduler): Improve OrderedNodesByTask parallelization#1548
davidLif wants to merge 4 commits into
mainfrom
DavidL/1546/improveOrderedNodesByTask

Conversation

@davidLif
Copy link
Copy Markdown
Collaborator

@davidLif davidLif commented May 5, 2026 •
edited
Loading

Description

Improve OrderedNodesByTask parallelization - do not create a separate go routine for each node. Rather, have a pool of workers (based on the https://github.com/panjf2000/ants library) split the work between them

Related Issues

Fixes #

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated documentation (if needed)

Breaking Changes

Additional Notes

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3f6dcb79-ada7-43f6-ae0a-a8a8b9b67cb0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch DavidL/1546/improveOrderedNodesByTask

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026 •
edited
Loading

📊 Performance Benchmark Results

Comparing PR (DavidL/1546/improveOrderedNodesByTask) vs main branch — click to expand 
goos: linux
goarch: amd64
pkg: github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions
cpu: AMD EPYC 7763 64-Core Processor                
                                    │ main-bench.txt │           pr-bench.txt            │
                                    │     sec/op     │   sec/op     vs base              │
AllocateAction_SmallCluster-4           108.0m ±  0%   108.3m ± 7%  +0.31% (p=0.009 n=6)
AllocateAction_MediumCluster-4          136.5m ±  0%   132.6m ± 1%  -2.86% (p=0.002 n=6)
AllocateAction_LargeCluster-4           210.8m ± 10%   201.3m ± 3%  -4.51% (p=0.002 n=6)
ReclaimAction_SmallCluster-4            102.9m ±  0%   103.6m ± 0%  +0.63% (p=0.002 n=6)
ReclaimAction_MediumCluster-4           105.9m ±  1%   106.0m ± 0%       ~ (p=0.589 n=6)
PreemptAction_SmallCluster-4            103.5m ±  0%   103.9m ± 0%  +0.32% (p=0.009 n=6)
PreemptAction_MediumCluster-4           110.4m ±  0%   110.2m ± 0%  -0.22% (p=0.026 n=6)
ConsolidationAction_SmallCluster-4      124.6m ±  1%   121.7m ± 0%  -2.32% (p=0.002 n=6)
ConsolidationAction_MediumCluster-4     287.8m ±  0%   264.2m ± 3%  -8.21% (p=0.002 n=6)
FullSchedulingCycle_SmallCluster-4      105.3m ±  0%   105.9m ± 0%  +0.59% (p=0.002 n=6)
FullSchedulingCycle_MediumCluster-4     121.6m ±  0%   118.4m ± 0%  -2.66% (p=0.002 n=6)
FullSchedulingCycle_LargeCluster-4      160.9m ±  2%   151.7m ± 2%  -5.73% (p=0.002 n=6)
ManyQueues_MediumCluster-4              138.5m ±  2%   135.4m ± 0%  -2.21% (p=0.002 n=6)
GangScheduling_MediumCluster-4          159.9m ±  1%   150.4m ± 0%  -5.91% (p=0.002 n=6)
geomean                                 134.5m         131.3m       -2.37%

                                    │ main-bench.txt │            pr-bench.txt            │
                                    │      B/op      │     B/op      vs base              │
AllocateAction_SmallCluster-4           2.197Mi ± 1%   2.228Mi ± 2%  +1.41% (p=0.002 n=6)
AllocateAction_MediumCluster-4          11.96Mi ± 0%   11.65Mi ± 0%  -2.56% (p=0.002 n=6)
AllocateAction_LargeCluster-4           41.45Mi ± 0%   39.36Mi ± 0%  -5.04% (p=0.002 n=6)
ReclaimAction_SmallCluster-4            914.4Ki ± 1%   919.4Ki ± 1%  +0.54% (p=0.026 n=6)
ReclaimAction_MediumCluster-4           3.000Mi ± 0%   3.000Mi ± 0%       ~ (p=0.699 n=6)
PreemptAction_SmallCluster-4            1.044Mi ± 1%   1.047Mi ± 1%       ~ (p=0.180 n=6)
PreemptAction_MediumCluster-4           4.243Mi ± 0%   4.231Mi ± 0%  -0.29% (p=0.002 n=6)
ConsolidationAction_SmallCluster-4      9.941Mi ± 0%   9.995Mi ± 0%  +0.55% (p=0.002 n=6)
ConsolidationAction_MediumCluster-4     89.35Mi ± 0%   88.71Mi ± 0%  -0.72% (p=0.002 n=6)
FullSchedulingCycle_SmallCluster-4      1.405Mi ± 0%   1.425Mi ± 1%  +1.47% (p=0.002 n=6)
FullSchedulingCycle_MediumCluster-4     6.980Mi ± 0%   6.824Mi ± 0%  -2.24% (p=0.002 n=6)
FullSchedulingCycle_LargeCluster-4      22.99Mi ± 0%   21.93Mi ± 0%  -4.60% (p=0.002 n=6)
ManyQueues_MediumCluster-4              16.42Mi ± 0%   16.11Mi ± 0%  -1.86% (p=0.002 n=6)
GangScheduling_MediumCluster-4          17.24Mi ± 0%   16.62Mi ± 0%  -3.59% (p=0.002 n=6)
geomean                                 7.039Mi        6.954Mi       -1.21%

                                    │ main-bench.txt │           pr-bench.txt            │
                                    │   allocs/op    │  allocs/op   vs base              │
AllocateAction_SmallCluster-4            35.01k ± 0%   34.93k ± 0%  -0.22% (p=0.002 n=6)
AllocateAction_MediumCluster-4           312.8k ± 0%   299.3k ± 0%  -4.32% (p=0.002 n=6)
AllocateAction_LargeCluster-4            1.338M ± 0%   1.258M ± 0%  -6.00% (p=0.002 n=6)
ReclaimAction_SmallCluster-4             8.203k ± 0%   8.232k ± 0%  +0.37% (p=0.002 n=6)
ReclaimAction_MediumCluster-4            26.14k ± 0%   26.17k ± 0%  +0.11% (p=0.002 n=6)
PreemptAction_SmallCluster-4             11.04k ± 0%   11.07k ± 0%  +0.26% (p=0.002 n=6)
PreemptAction_MediumCluster-4            38.58k ± 0%   38.60k ± 0%  +0.06% (p=0.002 n=6)
ConsolidationAction_SmallCluster-4       129.8k ± 0%   129.6k ± 0%  -0.17% (p=0.002 n=6)
ConsolidationAction_MediumCluster-4      1.306M ± 0%   1.281M ± 0%  -1.91% (p=0.002 n=6)
FullSchedulingCycle_SmallCluster-4       20.67k ± 0%   20.65k ± 0%  -0.07% (p=0.026 n=6)
FullSchedulingCycle_MediumCluster-4      168.3k ± 0%   162.0k ± 0%  -3.72% (p=0.002 n=6)
FullSchedulingCycle_LargeCluster-4       698.6k ± 0%   659.9k ± 0%  -5.55% (p=0.002 n=6)
ManyQueues_MediumCluster-4               350.6k ± 0%   337.1k ± 0%  -3.86% (p=0.002 n=6)
GangScheduling_MediumCluster-4           571.8k ± 0%   544.7k ± 0%  -4.74% (p=0.002 n=6)
geomean                                  118.7k        116.2k       -2.15%

pkg: github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/integration_tests/reclaim
                            │ main-bench.txt │           pr-bench.txt            │
                            │     sec/op     │   sec/op     vs base              │
ReclaimLargeJobs_10Node-4        105.3m ± 1%   105.5m ± 1%       ~ (p=0.699 n=6)
ReclaimLargeJobs_50Node-4        230.8m ± 1%   228.8m ± 3%       ~ (p=0.485 n=6)
ReclaimLargeJobs_100Node-4       380.9m ± 8%   391.8m ± 2%       ~ (p=0.394 n=6)
ReclaimLargeJobs_200Node-4       748.0m ± 1%   756.8m ± 6%       ~ (p=0.937 n=6)
ReclaimLargeJobs_500Node-4        2.362 ± 2%    2.518 ± 5%  +6.62% (p=0.009 n=6)
ReclaimLargeJobs_1000Node-4       7.095 ± 2%    7.696 ± 4%  +8.48% (p=0.002 n=6)
geomean                          698.4m        719.4m       +3.01%

                            │ main-bench.txt │            pr-bench.txt            │
                            │      B/op      │     B/op      vs base              │
ReclaimLargeJobs_10Node-4       2.009Mi ± 3%   2.015Mi ± 2%       ~ (p=0.310 n=6)
ReclaimLargeJobs_50Node-4       60.70Mi ± 0%   60.95Mi ± 0%  +0.41% (p=0.002 n=6)
ReclaimLargeJobs_100Node-4      121.4Mi ± 0%   122.0Mi ± 0%  +0.48% (p=0.002 n=6)
ReclaimLargeJobs_200Node-4      245.0Mi ± 0%   246.2Mi ± 0%  +0.48% (p=0.002 n=6)
ReclaimLargeJobs_500Node-4      628.2Mi ± 0%   631.2Mi ± 0%  +0.47% (p=0.002 n=6)
ReclaimLargeJobs_1000Node-4     1.281Gi ± 0%   1.288Gi ± 0%  +0.48% (p=0.002 n=6)
geomean                         120.0Mi        120.5Mi       +0.43%

                            │ main-bench.txt │           pr-bench.txt            │
                            │   allocs/op    │  allocs/op   vs base              │
ReclaimLargeJobs_10Node-4        22.21k ± 2%   22.25k ± 2%  +0.17% (p=0.039 n=6)
ReclaimLargeJobs_50Node-4        814.3k ± 0%   816.6k ± 0%  +0.28% (p=0.002 n=6)
ReclaimLargeJobs_100Node-4       1.620M ± 0%   1.624M ± 0%  +0.27% (p=0.002 n=6)
ReclaimLargeJobs_200Node-4       3.229M ± 0%   3.238M ± 0%  +0.27% (p=0.002 n=6)
ReclaimLargeJobs_500Node-4       8.081M ± 0%   8.103M ± 0%  +0.27% (p=0.002 n=6)
ReclaimLargeJobs_1000Node-4      16.25M ± 0%   16.29M ± 0%  +0.27% (p=0.002 n=6)
geomean                          1.522M        1.526M       +0.25%

pkg: github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions/reclaim
                            │ main-bench.txt │            pr-bench.txt            │
                            │     sec/op     │   sec/op     vs base               │
ReclaimWithMissingPVCJobs-4       12.71 ± 2%   15.21 ± 15%  +19.70% (p=0.002 n=6)

                            │ main-bench.txt │         pr-bench.txt          │
                            │      B/op      │     B/op      vs base         │
ReclaimWithMissingPVCJobs-4     4.116Gi ± 0%   4.115Gi ± 0%  ~ (p=0.093 n=6)

                            │ main-bench.txt │         pr-bench.txt         │
                            │   allocs/op    │  allocs/op   vs base         │
ReclaimWithMissingPVCJobs-4      20.97M ± 0%   20.97M ± 0%  ~ (p=0.937 n=6)

Legend

  • 📉 Negative delta = Performance improvement (faster)
  • 📈 Positive delta = Performance regression (slower)
  • p-value < 0.05 indicates statistically significant change
Raw benchmark data

PR branch:

goos: linux
goarch: amd64
pkg: github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions
cpu: AMD EPYC 7763 64-Core Processor                
BenchmarkAllocateAction_SmallCluster-4         	       9	 116438669 ns/op	 2374659 B/op	   34942 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108333123 ns/op	 2338317 B/op	   34932 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108359421 ns/op	 2334784 B/op	   34932 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108273506 ns/op	 2334123 B/op	   34929 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108176022 ns/op	 2338856 B/op	   34937 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108353365 ns/op	 2333816 B/op	   34926 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 132918518 ns/op	12223229 B/op	  299253 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 132774341 ns/op	12223273 B/op	  299288 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 132370660 ns/op	12221205 B/op	  299274 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 134380730 ns/op	12219898 B/op	  299264 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 132429270 ns/op	12218675 B/op	  299270 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 131879714 ns/op	12220973 B/op	  299249 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       6	 201077900 ns/op	41271452 B/op	 1257868 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       6	 203730696 ns/op	41271452 B/op	 1257881 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       6	 207646511 ns/op	41270480 B/op	 1257855 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       6	 201503977 ns/op	41271357 B/op	 1257897 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       6	 196939274 ns/op	41279114 B/op	 1257946 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       6	 199974743 ns/op	41284598 B/op	 1257874 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 103635931 ns/op	  940594 B/op	    8230 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 103842884 ns/op	  941532 B/op	    8233 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 103888360 ns/op	  941362 B/op	    8232 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 103501116 ns/op	  941720 B/op	    8234 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 103544791 ns/op	  933610 B/op	    8229 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 103510181 ns/op	  946432 B/op	    8233 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105982541 ns/op	 3149456 B/op	   26176 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105809230 ns/op	 3149317 B/op	   26174 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 106291536 ns/op	 3145348 B/op	   26173 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 106051780 ns/op	 3141293 B/op	   26173 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105965191 ns/op	 3144780 B/op	   26172 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105681058 ns/op	 3145162 B/op	   26174 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 104150380 ns/op	 1090029 B/op	   11070 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 104060501 ns/op	 1093968 B/op	   11071 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103893813 ns/op	 1098056 B/op	   11073 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103774727 ns/op	 1098644 B/op	   11075 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103775603 ns/op	 1100645 B/op	   11072 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103844592 ns/op	 1098386 B/op	   11075 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 109780354 ns/op	 4436256 B/op	   38599 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 110268525 ns/op	 4436210 B/op	   38599 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 109988719 ns/op	 4436340 B/op	   38600 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 110119036 ns/op	 4436493 B/op	   38600 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 110536319 ns/op	 4436493 B/op	   38600 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 110188495 ns/op	 4436629 B/op	   38600 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 121806247 ns/op	10483479 B/op	  129565 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 121678339 ns/op	10480163 B/op	  129553 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 121402413 ns/op	10481000 B/op	  129551 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 122231546 ns/op	10479521 B/op	  129551 allocs/op

Main branch:

goos: linux
goarch: amd64
pkg: github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/actions
cpu: AMD EPYC 7763 64-Core Processor                
BenchmarkAllocateAction_SmallCluster-4         	      10	 107797072 ns/op	 2305492 B/op	   35006 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107966624 ns/op	 2308524 B/op	   35011 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107983213 ns/op	 2315708 B/op	   35010 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108187329 ns/op	 2298644 B/op	   35004 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108041132 ns/op	 2302708 B/op	   35010 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108178845 ns/op	 2299616 B/op	   35005 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 136552859 ns/op	12542564 B/op	  312787 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 137089156 ns/op	12545242 B/op	  312786 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 136449210 ns/op	12541989 B/op	  312783 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 136149310 ns/op	12542939 B/op	  312789 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 136062863 ns/op	12540819 B/op	  312774 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 136974014 ns/op	12542245 B/op	  312784 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 212026619 ns/op	43467083 B/op	 1338175 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 210173100 ns/op	43457529 B/op	 1338144 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 232304791 ns/op	43463235 B/op	 1338173 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 211425102 ns/op	43460508 B/op	 1338164 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 208576879 ns/op	43457860 B/op	 1338141 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 208404109 ns/op	43468744 B/op	 1338174 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102821490 ns/op	  925764 B/op	    8172 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102835347 ns/op	  929834 B/op	    8187 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102953787 ns/op	  937932 B/op	    8202 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102937294 ns/op	  938879 B/op	    8205 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102949338 ns/op	  938309 B/op	    8203 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102994798 ns/op	  934840 B/op	    8203 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 106599031 ns/op	 3145792 B/op	   26145 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105678071 ns/op	 3146879 B/op	   26145 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105827102 ns/op	 3145973 B/op	   26146 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105618061 ns/op	 3145544 B/op	   26144 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105908902 ns/op	 3146005 B/op	   26146 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105998732 ns/op	 3141938 B/op	   26144 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103776472 ns/op	 1091327 B/op	   11043 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103140389 ns/op	 1095133 B/op	   11044 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103427767 ns/op	 1095101 B/op	   11044 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103577145 ns/op	 1087210 B/op	   11041 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103501481 ns/op	 1095040 B/op	   11044 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103590779 ns/op	 1095181 B/op	   11045 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 110935467 ns/op	 4441524 B/op	   38574 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 110416854 ns/op	 4449489 B/op	   38577 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 110666184 ns/op	 4449348 B/op	   38577 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 110381717 ns/op	 4449528 B/op	   38578 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 110307594 ns/op	 4449624 B/op	   38577 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	      10	 110326297 ns/op	 4441282 B/op	   38573 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 123636139 ns/op	10416755 B/op	  129761 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 125005955 ns/op	10438149 B/op	  129798 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 124937666 ns/op	10432087 B/op	  129754 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 124669042 ns/op	10422113 B/op	  129801 allocs/op

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/framework 35.24% (-0.77%) 👎
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/framework/session.go 0.49% (-0.05%) 205 (+18) 1 204 (+18) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

davidLif added 2 commits May 5, 2026 23:20
@davidLif
Improve OrderedNodesByTask parallelization - do not create a separate…
94abbb4 
… go routine for each node. Rather, have a pool of workers split the work between them

Signed-off-by: davidLif <[email protected]>
@davidLif
Use ants goroutine pool initialized at the start of the session inste…
99c6919 
…ad of each time creating a new pool of goroutines

Signed-off-by: davidLif <[email protected]>
@davidLif davidLif force-pushed the DavidL/1546/improveOrderedNodesByTask branch from f29ed9d to 99c6919 Compare May 5, 2026 20:20
davidLif added 2 commits May 5, 2026 23:25
@davidLif
Refactor code for cleanliness
4996129 
Signed-off-by: davidLif <[email protected]>
@davidLif
s1
64ac3b7 
Signed-off-by: davidLif <[email protected]>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/framework 34.34% (-1.67%) 👎
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/test_utils 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/framework/session.go 0.44% (-0.09%) 227 (+40) 1 226 (+40) 👎
github.com/kai-scheduler/KAI-scheduler/pkg/scheduler/test_utils/test_utils_builder.go 0.00% (ø) 135 (+2) 0 135 (+2)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@davidLif