-
Notifications
You must be signed in to change notification settings - Fork 191
feat(podgrouper): support externally created pod groups #1552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
enoodle
merged 6 commits into
kai-scheduler:main
from
enoodle:erez/bring-your-own-pod-group-implementation
May 12, 2026
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
eb4bf77
feat(podgrouper): support explicit skip-podgrouper annotation
enoodle ad861f8
feat(scheduler): surface invalid subgroup labels on pods
enoodle 99ef95e
docs(batch): add external PodGroup usage guidance
enoodle 5a75724
test(e2e): cover external PodGroup batch job
enoodle e98b4cc
docs(changelog): document external PodGroup support
enoodle 65c77fc
Merge branch 'main' into erez/bring-your-own-pod-group-implementation
enoodle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # Copyright 2025 NVIDIA CORPORATION | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| # This example demonstrates how to use an externally-created PodGroup with a | ||
| # batch Job. The PodGroup is created explicitly and the Job opts out of | ||
| # podgrouper reconciliation while attaching its pods to the external PodGroup. | ||
|
|
||
| apiVersion: scheduling.run.ai/v2alpha2 | ||
| kind: PodGroup | ||
| metadata: | ||
| name: external-batch-job | ||
| spec: | ||
| minMember: 2 | ||
| queue: default-queue | ||
| subGroups: | ||
| - name: workers | ||
| minMember: 2 | ||
| --- | ||
| apiVersion: batch/v1 | ||
| kind: Job | ||
| metadata: | ||
| name: external-batch-job | ||
| annotations: | ||
| kai.scheduler/skip-podgrouper: "true" | ||
| spec: | ||
| parallelism: 2 | ||
| completions: 2 | ||
| template: | ||
| metadata: | ||
| annotations: | ||
| pod-group-name: external-batch-job | ||
| labels: | ||
| kai.scheduler/subgroup-name: workers | ||
| spec: | ||
| schedulerName: kai-scheduler | ||
| restartPolicy: Never | ||
| containers: | ||
| - name: main | ||
| image: ubuntu | ||
| args: ["sleep", "infinity"] | ||
| resources: | ||
| limits: | ||
| nvidia.com/gpu: "1" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.