Skip to content

Add permissions to create watch and update events for operator#1572

Merged
davidLif merged 2 commits into
kai-scheduler:mainfrom
dttung2905:fix-event-emission-bug
May 10, 2026
Merged

Add permissions to create watch and update events for operator#1572
davidLif merged 2 commits into
kai-scheduler:mainfrom
dttung2905:fix-event-emission-bug

Conversation

@dttung2905
Copy link
Copy Markdown
Contributor

Description

Add permissions to create watch and update events for operator to fix #1571

Related Issues

Fixes #1571

Checklist

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated documentation (if needed)

Breaking Changes

no breaking changes

Additional Notes

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 8, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2d27b308-c41b-440e-8b50-0a9d9bc82d2f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: dttung2905 <[email protected]>
@github-actions
Copy link
Copy Markdown

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/kai-scheduler/KAI-scheduler/cmd/operator/app 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/kai-scheduler/KAI-scheduler/cmd/operator/app/app.go 0.00% (ø) 42 0 42

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@davidLif davidLif added this pull request to the merge queue May 10, 2026
Merged via the queue into kai-scheduler:main with commit 2299503 May 10, 2026
17 of 19 checks passed
@KaiPilotBot
Copy link
Copy Markdown

Backport failed for v0.9, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin v0.9
git worktree add -d .worktree/backport-1572-to-v0.9 origin/v0.9
cd .worktree/backport-1572-to-v0.9
git switch --create backport-1572-to-v0.9
git cherry-pick -x 084997b46d88dff76c871dfb8d0f8b05872caa80 6bc59eff2eb65b977c06c036da4fee9e120dae63

@KaiPilotBot
Copy link
Copy Markdown

Backport failed for v0.6, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin v0.6
git worktree add -d .worktree/backport-1572-to-v0.6 origin/v0.6
cd .worktree/backport-1572-to-v0.6
git switch --create backport-1572-to-v0.6
git cherry-pick -x 084997b46d88dff76c871dfb8d0f8b05872caa80 6bc59eff2eb65b977c06c036da4fee9e120dae63

@KaiPilotBot
Copy link
Copy Markdown

Successfully created backport PR for v0.12:

@KaiPilotBot
Copy link
Copy Markdown

Successfully created backport PR for v0.14:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kai-operator unable to fire events after leader election completed

4 participants