feat: snapshots skill#1659
Conversation
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
|
|
||
| ### Codex | ||
|
|
||
| Codex can consume skills from `.agents/skills/` when working inside this repository. |
There was a problem hiding this comment.
And how will Codex know where to look for this skill? You do have an ln command for claude
There was a problem hiding this comment.
It knows to look at .agents (https://developers.openai.com/codex/skills#where-to-save-skills) it is a common location to set such skills (see NemoClaw for example)
| cleanup() { | ||
| if [[ -n "$port_forward_pid" ]] && kill -0 "$port_forward_pid" >/dev/null 2>&1; then | ||
| kill "$port_forward_pid" >/dev/null 2>&1 || true | ||
| wait "$port_forward_pid" >/dev/null 2>&1 || true |
There was a problem hiding this comment.
because of how we setup the port-forward it is not expected to resist the kill command. I can add a timeout anyway
|
|
||
| - `inspect-snapshot.sh`: validate that the archive contains `snapshot.json` and print top-level structure. Run this before replaying user-provided artifacts. | ||
| - `run-snapshot.sh`: build `snapshot-tool` with `make build-go SERVICE_NAME=snapshot-tool` and replay on the current checkout, or use `--ref` to switch to one Git ref, replay, and restore the original branch or commit. For large snapshots, start with `--verbosity 2`. For reruns, prefer `--no-build --tool bin/snapshot-tool-amd64`. If a ref-based run is interrupted hard enough that the shell trap does not execute, the repo can stay detached; check with `git status --short --branch` and restore with `git switch <branch>`. | ||
| - `compare-snapshot-refs.sh`: run the same snapshot against several refs and save one log per ref plus `summary.tsv`. |
There was a problem hiding this comment.
Please explain the script in more details - why do we need it? compares the snapshot against what?
There was a problem hiding this comment.
I will add the word "git" to make it more clear, I don't want to add too many extra words in the skill. It is used to run the same snapshot against different git references to find regressions or compare results. Also usually people will install a tagged version but a developer might have the main checked out or a specific branch - so the developer / agent might want to run the snapshot against a different version than the current local one.
2 participants
Description
Adding skills for agents to take snapshots and run on on KAI
Related Issues
Closes #1517
Checklist
Breaking Changes
Additional Notes