feat(chart): Add ability to change security and resources for the Helm chart#1661
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…m chart Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
3bfa213 to
9d2455e
Compare
Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
|
@treydock Why add resources configuration to those helm jobs and not just set some constant? I am not sure that it is really helpful to play with this value and maybe we should keep it a little bit more simple by just setting a value. |
Setting some value is good but I'd imagine it's possible the value set would need to be overridden. I figured leaving empty leaves it undefined like before but allows sites that want resource limits to be able to set them. We use Kyverno to ensure things we deploy are setting resource requests and limits so having some value set is necessary but also can't assume a hardcoded default is always sufficient I'd imagine. |
Description
Add several new configuration options for Helm.
Checklist