Skip to content

feat(chart): Add ability to change security and resources for the Helm chart#1661

Merged
enoodle merged 2 commits into
kai-scheduler:mainfrom
treydock:helm-improvements
Jun 3, 2026
Merged

feat(chart): Add ability to change security and resources for the Helm chart#1661
enoodle merged 2 commits into
kai-scheduler:mainfrom
treydock:helm-improvements

Conversation

@treydock
Copy link
Copy Markdown
Contributor

@treydock treydock commented Jun 2, 2026

Description

Add several new configuration options for Helm.

  • Ensure all Job and Deployment resources can support securityContexts
  • Ensure Jobs and Deployments can have resources defined

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated documentation (if needed)

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 2, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 76d41eb8-3aad-43c0-a20e-b989030e32ae

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…m chart

Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
@treydock treydock force-pushed the helm-improvements branch from 3bfa213 to 9d2455e Compare June 2, 2026 15:54
@treydock treydock marked this pull request as ready for review June 2, 2026 16:11
Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
@enoodle
Copy link
Copy Markdown
Collaborator

enoodle commented Jun 3, 2026

@treydock Why add resources configuration to those helm jobs and not just set some constant? I am not sure that it is really helpful to play with this value and maybe we should keep it a little bit more simple by just setting a value.

@treydock
Copy link
Copy Markdown
Contributor Author

treydock commented Jun 3, 2026

Why add resources configuration to those helm jobs and not just set some constant? I am not sure that it is really helpful to play with this value and maybe we should keep it a little bit more simple by just setting a value.

Setting some value is good but I'd imagine it's possible the value set would need to be overridden. I figured leaving empty leaves it undefined like before but allows sites that want resource limits to be able to set them. We use Kyverno to ensure things we deploy are setting resource requests and limits so having some value set is necessary but also can't assume a hardcoded default is always sufficient I'd imagine.

@enoodle enoodle added this pull request to the merge queue Jun 3, 2026
Merged via the queue into kai-scheduler:main with commit 0fe3c86 Jun 3, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants