Skip to content

beatstars user check#332

Merged
kaifcodec merged 8 commits into
kaifcodec:mainfrom
notlorick:main
May 11, 2026
Merged

beatstars user check#332
kaifcodec merged 8 commits into
kaifcodec:mainfrom
notlorick:main

Conversation

@notlorick

Copy link
Copy Markdown
Contributor

No description provided.

@kaifcodec

Copy link
Copy Markdown
Owner

@notlorick Thanks for opening the PR, I’ve reviewed both modules.

beatstars.py looks good and works as expected. However, the VK module is returning a 301 status code. Could you test it again on your side and confirm?

@kaifcodec kaifcodec added the need-extra-changes Some files or parts of the code may require additional edits or updates for it work properly. label May 7, 2026
@notlorick

Copy link
Copy Markdown
Contributor Author

code is a bit uglier now, but it should work as expected

@kaifcodec kaifcodec requested a review from json-hunter07 May 10, 2026 06:21
@kaifcodec

Copy link
Copy Markdown
Owner

@json-hunter07 Take a look at this. If you think any improvements can be made to the error handling, feel free to proceed with them.

@json-hunter07

json-hunter07 commented May 11, 2026

Copy link
Copy Markdown
Collaborator

@kaifcodec I have improved the error handling and edge cases in the beatstars module.
Now it correctly handles the error.
However I also do think that instead of reporting the invalid length as an error to reporting it as not found but passing the message would be a good idea.

@kaifcodec

Copy link
Copy Markdown
Owner

@json-hunter07 Good improvement on the error handling and edge cases in the beatstars module.

And yes, I also think treating invalid length as not found while still passing the message/details would make more sense than reporting it as a hard error.

@kaifcodec

Copy link
Copy Markdown
Owner

@notlorick Thank you for the PR, if want to contribute further feel free to add the email validation of these sites or any new sites that aren't already covered.

@kaifcodec kaifcodec merged commit 96e9dd9 into kaifcodec:main May 11, 2026
2 checks passed
@kaifcodec kaifcodec added the user module addition PRs or issues related to new user_scan module additions label May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need-extra-changes Some files or parts of the code may require additional edits or updates for it work properly. user module addition PRs or issues related to new user_scan module additions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants