Skip to content

chore: cleanup verbose logs - #1420

Merged
Fei-Guo merged 1 commit into
kaito-project:mainfrom
bfoley13:brfole/log-cleanup
Aug 21, 2025
Merged

chore: cleanup verbose logs#1420
Fei-Guo merged 1 commit into
kaito-project:mainfrom
bfoley13:brfole/log-cleanup

Conversation

@bfoley13

@bfoley13 bfoley13 commented Aug 21, 2025

Copy link
Copy Markdown
Collaborator

Reason for Change:
Cleanup overly verbose logging. These logs dump the prompts which can be very slow for large prompts

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

@kaito-pr-agent

Copy link
Copy Markdown
Contributor

Title

Enhance logging by removing verbosity and improving log message clarity


Description

  • Removed verbose logging for chat engine creation

  • Replaced prompt content with prompt size in log message


Changes walkthrough 📝

Relevant files
Enhancement
base.py
Improve logging clarity and reduce verbosity                         

presets/ragengine/vector_store/base.py

  • Removed verbose=True parameter from as_chat_engine method
  • Updated log message to include prompt size instead of full prompt
    content
  • +1/-2     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @kaito-pr-agent

    Copy link
    Copy Markdown
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Logging Information

    The log message now includes prompt_size instead of the full prompt. Ensure that prompt_size provides sufficient information for debugging without exposing potentially sensitive data.

    f"Creating chat engine for index '{request.get('index_name')}' with prompt size: {prompt_len}"

    @Fei-Guo
    Fei-Guo merged commit 88d5e73 into kaito-project:main Aug 21, 2025
    15 of 17 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    Status: Done

    Development

    Successfully merging this pull request may close these issues.

    2 participants