improve a11y

kamikidd · Jul 5, 2024 · 0e627b9 · 0e627b9
1 parent 3ca83a8
commit 0e627b9
Show file tree

Hide file tree

Showing 8 changed files with 19 additions and 22 deletions.
diff --git a/dist/assets/index.648b68d5.js → dist/assets/index.80643fa4.js b/dist/assets/index.648b68d5.js → dist/assets/index.80643fa4.js
diff --git a/dist/index.html b/dist/index.html
@@ -6,7 +6,7 @@
     <title>Buero Vatter</title>
 
 
-    <script type="module" crossorigin src="/bv2024_frontend/assets/index.648b68d5.js"></script>
+    <script type="module" crossorigin src="/bv2024_frontend/assets/index.80643fa4.js"></script>
     <link rel="stylesheet" href="/bv2024_frontend/assets/index.9b4ebce4.css">
   </head>
   <body>

diff --git a/src/pages/Projects/ProjectDetail.jsx b/src/pages/Projects/ProjectDetail.jsx
@@ -48,7 +48,7 @@ const ProjectDetail = () => {
                 <Col className={`${styles.detail_right}`} xl={9}>
                   {partners.map((line, index) => (
                     <ul className={`${styles.partner}`} key={index}>
-                      {line}
+                      <li>{line}</li>
                     </ul>
                   ))}
                 </Col>
@@ -98,7 +98,7 @@ const ProjectDetail = () => {
                 <Col className={`${styles.detail_right}`} xl={9}>
                   {methods.map((line, index) => (
                     <ul className={`${styles.method}`} key={index}>
-                      -{line}
+                      <li>-{line}</li>
                     </ul>
                   ))}
                 </Col>

diff --git a/src/pages/Projects/SelectComp.jsx b/src/pages/Projects/SelectComp.jsx
@@ -3,14 +3,7 @@ import { useEffect, useState } from "react";
 import styles from "./select.module.css";
 import { useSearchParams } from "react-router-dom";
 
-const SelectComp = ({
-  isPreSelected,
-  value,
-  onChange,
-  options,
-  type,
-  url,
-}) => {
+const SelectComp = ({ isPreSelected, value, onChange, options, type, url }) => {
   const [isOpen, setIsOpen] = useState(false);
   const [searchParams, setSearchParams] = useSearchParams("");
   const [showClearButton, setShowClearButton] = useState(
@@ -94,7 +87,7 @@ const SelectComp = ({
       <ul className={`${styles.options}  ${isOpen ? styles.show : ""}`}>
         {options.map((option, index) => (
           // eslint-disable-next-line jsx-a11y/click-events-have-key-events, jsx-a11y/no-noninteractive-element-interactions
-          <ul
+          <li
             onClick={(e) => {
               e.stopPropagation();
               selectOption(option.title.rendered);
@@ -119,7 +112,7 @@ const SelectComp = ({
             } ${index == highlightedIndex ? styles.highlighted : ""}`}
           >
             {option.title.rendered}
-          </ul>
+          </li>
         ))}
       </ul>
     </div>

diff --git a/src/pages/Projects/projects.module.css b/src/pages/Projects/projects.module.css
@@ -200,11 +200,13 @@
 .partner {
     padding-left: 0;
     margin-bottom: 0;
+    list-style-type: none;
 }
 
 .method {
     padding-left: 0;
     margin-bottom: 0;
+    list-style-type: none;
 }
 
 div.project_detail_title.col {

diff --git a/src/pages/Projects/select.module.css b/src/pages/Projects/select.module.css
@@ -117,7 +117,7 @@
     z-index: 100;
     transition: max-height 0.4s;
     overflow: hidden;
-
+    list-style-type: none;
     /* display: none; */
     /* max-height: 30em; */
     /* overflow-y: hidden; */
@@ -137,7 +137,7 @@
     font-family: 'Barlow Condensed', sans-serif;
     font-size: 24px;
     font-weight: 400;
-    letter-spacing: -0.9px;
+    letter-spacing: -1px;
     color: #000000;
 
 

diff --git a/src/pages/Staffs/StaffDetailCompLeft.jsx b/src/pages/Staffs/StaffDetailCompLeft.jsx
@@ -30,9 +30,9 @@ const StaffDetailCompLeft = ({ staff }) => {
           <div className={`${styles.staff_info}`}>{staff.acf.position}</div>
           <ul className={`${styles.staff_info_position_higher}`}>
             {information.map((line, index) => (
-              <ul className={`${styles.info_line}`} key={index}>
+              <li className={`${styles.info_line}`} key={index}>
                 {line}
-              </ul>
+              </li>
             ))}
           </ul>
           <div className={`${styles.staff_detail_left_bottom_element}`}>

diff --git a/src/pages/Staffs/staffs.module.css b/src/pages/Staffs/staffs.module.css
@@ -74,11 +74,13 @@ ul.staff_info_position_higher {
     font-size: 20px;
     font-weight: 400;
     padding-left: 0px;
+    list-style-type: none;
 }
 
 .info_line {
     padding-left: 0px;
     text-align: center;
+
 }
 
 div.staff_info_position_lower {