Fix ffmpeg int on win

kapoorlakshya · Jul 21, 2024 · 0296237 · 0296237
1 parent c71e79a
commit 0296237
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/lib/screen-recorder/childprocess.rb b/lib/screen-recorder/childprocess.rb
@@ -127,13 +127,12 @@ def kill
 
     def send_signal(sig)
       ScreenRecorder.logger.debug("Sending #{sig} to process: #{@pid}")
-      if OS.linux? || OS.mac?
-        Process.kill sig, -@pid # negative pid == process group
-      else
-        signal = sig == SIGTERM ? '/T' : '/T /F'
-        output = `taskkill #{signal} /PID #{@pid}`
-        ScreenRecorder.logger.debug("taskkill: #{output}") unless output.empty?
+      if OS.windows?
+        Process.kill sig, @pid # process only
+        return
       end
+
+      Process.kill sig, -@pid # negative pid == process group
     end
 
     def waitpid2(pid, flags = 0)
@@ -142,4 +141,4 @@ def waitpid2(pid, flags = 0)
       true # already dead
     end
   end # ChildProcess
-end # Common
+end # Common