added code to flatten chunks for infinite maps. Please note that I di…#288
Open
aburkes wants to merge 2 commits intokarai17:masterfrom
Open
added code to flatten chunks for infinite maps. Please note that I di…#288aburkes wants to merge 2 commits intokarai17:masterfrom
aburkes wants to merge 2 commits intokarai17:masterfrom
Conversation
…d not remove all code that works with chunks, but I set chunks to nil after copying the data so the majority of that code should never run.
Author
|
I took this off after I realized that only the first chunk had it's properties copied! I'll figure out what's happening and fix it before I resubmit. |
Author
|
Ah, lordy, I spent hours and rewrote this three times only to find out that the bug was actually in my test code. Such is life. |
…rs if they have chunk rows that are do not have tiles in them, so I added an if statement that prevents it from crashing and returns the correct nil values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d not remove all code that works with chunks, but I set chunks to nil after copying the data so the majority of that code should never run.