-
Notifications
You must be signed in to change notification settings - Fork 13
Sync APIs from karmada repo based on v1.15.0 #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @RainbowMango, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the API definitions to align with the v1.15.0 release of the karmada-io/karmada project. The changes primarily enhance the system's ability to manage complex, multi-component applications by providing granular control over resource interpretation and binding. Additionally, it improves cluster API compatibility checks, refines failover strategies, and introduces network proxy support for external resource downloads, alongside routine dependency upgrades.
Highlights
- API Synchronization: Synchronized APIs from karmada-io/karmada v1.15.0, ensuring compatibility with the latest upstream changes.
- Multi-Component Workload Support: Introduced new API fields and interpretation logic to support workloads with multiple pod templates (e.g., FlinkDeployment), allowing for component-specific resource requirements and scheduling.
- Cluster API Enablement Check: Added a new function to determine if a specific Kubernetes API (GroupVersionKind) is enabled on a cluster, improving visibility into cluster capabilities.
- Failover Behavior Enhancements: Refined PurgeMode options for failover with clearer terminology (Directly, Gracefully) and added configuration for cluster-level failover behavior, including state preservation.
- CRD Download Proxy Support: Enabled proxy configuration for downloading CRD tarballs via HTTP/HTTPS, facilitating deployments in restricted network environments.
- Dependency Updates: Updated Go version to 1.24.6 and Kubernetes dependencies (k8s.io/api, apiextensions-apiserver, apimachinery) to v0.33.2, along with sigs.k8s.io/controller-runtime to v0.21.0.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request syncs APIs from Karmada v1.15.0, introducing several enhancements and new features. Key changes include updating Go and Kubernetes dependencies, adding support for multi-component workloads through new API fields and interpreter operations, and enabling proxy configuration for downloading CRD tarballs. Additionally, failover behavior has been refined with new purge modes and the activation of cluster-level failover configuration. The code is generally well-structured and the changes are clearly documented. I have one minor suggestion regarding API consistency in a newly added struct.
Signed-off-by: RainbowMango <[email protected]>
38bfbd5
to
7cae8f4
Compare
This PR syncs APIs from karmada-io/karmada release v1.15.0.