-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove "time" field from dataset if no time column exists #429
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #429 +/- ##
==========================================
+ Coverage 94.04% 94.09% +0.04%
==========================================
Files 259 259
Lines 15841 15865 +24
==========================================
+ Hits 14898 14928 +30
+ Misses 943 937 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@osundwajeff the to_json code is in ObservationParquetReaderValue and it's not calling to_json in parent class. So your change is not called by ObservationParquetReaderValue. Have you tested your changes? you can use arable parquet data in staging.
def to_json(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @osundwajeff
#428