Fix byte-concat handling for single 0x00 byte payloads#49
Open
michaelsutton wants to merge 2 commits intokaspanet:masterfrom
Open
Fix byte-concat handling for single 0x00 byte payloads#49michaelsutton wants to merge 2 commits intokaspanet:masterfrom
0x00 byte payloads#49michaelsutton wants to merge 2 commits intokaspanet:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a compiler emission bug where pushing a single zero byte (
[0x00]) was canonicalized toOP_0(empty bytes), which broke byte concatenation cases likebyte[] + byte + byte[]when the middle byte was zero.It introduces a
ScriptBuilderextension method (add_data_preserving_single_zero) that emits exact one-byte zero payloads via0 1 OP_NUM2BIN, and uses it across compiler byte/data push paths.Added regression tests cover zero-byte concat and the
byte/byte[1]/byte[]single-zero forms.