-
Notifications
You must be signed in to change notification settings - Fork 409
add precommit skill #907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adilhafeez
wants to merge
1
commit into
main
Choose a base branch
from
adil/precommit-skill
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+61
−0
Open
add precommit skill #907
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| --- | ||
| name: precommit | ||
| description: Run pre-commit hooks and fix any failures. Use when the user asks to run pre-commit, fix CI, fix clippy, fix formatting, or when preparing code for a PR. | ||
| --- | ||
|
|
||
| # Fix Pre-commit Failures | ||
|
|
||
| Run pre-commit and fix all failures before committing or pushing. | ||
|
|
||
| ## Run it | ||
|
|
||
| ```bash | ||
| cd /Users/ahafeez/dev/plano && pre-commit run --all-files | ||
| ``` | ||
|
|
||
| Requires `["all"]` sandbox permissions (jemalloc build needs temp dir access). | ||
|
|
||
| ## Hooks and how to fix each | ||
|
|
||
| ### check-yaml | ||
| YAML syntax errors. Fix the YAML file directly. Excludes `config/envoy.template*`. | ||
|
|
||
| ### end-of-file-fixer / trailing-whitespace | ||
| Auto-fixed by the hook. Just re-stage the files and re-run. | ||
|
|
||
| ### cargo-fmt | ||
| ```bash | ||
| cd crates && cargo fmt --all | ||
| ``` | ||
| Then re-stage changed files. | ||
|
|
||
| ### cargo-clippy | ||
| Runs `cargo clippy --locked --all-targets --all-features -- -D warnings`. | ||
|
|
||
| Common fixes: | ||
| - `collapsible_match`: Collapse `if` inside a `match` arm into a guard clause. Add a fallthrough arm if the guard makes the match non-exhaustive. | ||
| - `dead_code`: Remove unused fields/functions, or add `#[allow(dead_code)]` if intentional. | ||
| - `unused_imports`: Remove the import. | ||
| - `clippy::too_many_arguments`: Add `#[allow(clippy::too_many_arguments)]`. | ||
|
|
||
| **Important**: Clippy runs on the full workspace including `hermesllm`, `common`, `llm_gateway`, `prompt_gateway` — not just `brightstaff`. Pre-existing warnings in other crates will fail CI too. Fix them. | ||
|
|
||
| ### cargo-test | ||
| ```bash | ||
| cd crates && cargo test --lib | ||
| ``` | ||
| Fix failing tests. If a test fails due to your change, update the test. If it's pre-existing, still fix it. | ||
|
|
||
| ### gitleaks | ||
| Hardcoded secrets detected. Remove the secret, use env vars instead. | ||
|
|
||
| ### black | ||
| Python formatting. Auto-fixes on first run. Re-stage and re-run. | ||
|
|
||
| ## Workflow | ||
|
|
||
| 1. Run `pre-commit run --all-files` | ||
| 2. For each failure: fix the issue | ||
| 3. Stage fixes with `git add` | ||
| 4. Run `pre-commit run --all-files` again until all pass | ||
| 5. Then commit | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to just the command not the pwd