ci: add zero-config smoke test for planoai up with no args#919
Merged
adilhafeez merged 1 commit intomainfrom Apr 25, 2026
Merged
ci: add zero-config smoke test for planoai up with no args#919adilhafeez merged 1 commit intomainfrom
planoai up with no args#919adilhafeez merged 1 commit intomainfrom
Conversation
The existing native-smoke-test always passes a config file, so the `synthesize_default_config` branch in `cli/planoai/main.py` is never exercised in CI. That branch was the source of a recent UnboundLocalError that only reproduced when invoking `planoai up` with no args in a directory without a `plano.yaml` (fixed in #916). Add a follow-up step in the same job that runs `planoai up` from an empty temp directory, asserts `~/.plano/default_config.yaml` is written, performs a healthz check, and shuts down. Reuses the binaries already built earlier in the job to keep CI time flat. Made-with: Cursor
Spherrrical
approved these changes
Apr 24, 2026
adilhafeez
force-pushed
the
adil/ci-zero-config-smoke-test
branch
from
156b893 to
fe5371a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
native-smoke-testonly ever runsplanoai up <file>, which skips thesynthesize_default_configbranch incli/planoai/main.py. That branch is the path users hit when they runplanoai upwith no args in a directory that has noplano.yaml, and it was the source of the recentUnboundLocalError: cannot access local variable 'yaml'(fixed in fix(cli): drop function-localimport yamlshadowing module global inup#916).cds into an empty temp directory, runsplanoai up, asserts~/.plano/default_config.yamlwas written, performs a healthz check on:12000, and shuts down.Test plan
main(post-fix(cli): drop function-localimport yamlshadowing module global inup#916).import yamlshadowing module global inup#916 on a scratch branch and confirm the new step fails with the sameUnboundLocalError.Made with Cursor