Skip to content

Optimize docker build #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize docker build #343

wants to merge 1 commit into from

Conversation

palagdan
Copy link
Collaborator

resolve #319

@palagdan palagdan requested a review from blcham March 31, 2025 11:12
blcham
blcham reviewed Mar 31, 2025
View reviewed changes
Dockerfile

COPY ./ ./

RUN mvn -B de.qaware.maven:go-offline-maven-plugin:resolve-dependencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

command before should instead do something like find pom.xml -exec cp ...

blcham
blcham requested changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment

@blcham
Copy link
Contributor

blcham commented Mar 31, 2025

test it locally to find out if it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blcham blcham blcham requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optimize docker build to cache dependencies from pom.xml

2 participants

@palagdan @blcham