Skip to content

Refactor dependencies in s-pipes-core, forms and model #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Refactor dependencies in s-pipes-core, forms and model #428

wants to merge 12 commits into from

Conversation

MSattrtand
Copy link
Collaborator

Resolves partially #332

@MSattrtand
Copy link
Collaborator Author

I've updated the s-pipes-core, model, and forms as stated in the original issue. Since core is dependent on test and forms on modules-form, I have updated them too.

@blcham blcham self-requested a review September 4, 2025 08:58
blcham
blcham requested changes Sep 4, 2025
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments, after it is fixed i will do the review again

@MSattrtand MSattrtand force-pushed the 332-fix-dependencies-in-core branch 2 times, most recently from b3beee4 to cbfc385 Compare September 4, 2025 11:34
@MSattrtand MSattrtand requested a review from blcham September 8, 2025 10:16
@MSattrtand MSattrtand force-pushed the 332-fix-dependencies-in-core branch from cbfc385 to 14e142b Compare September 12, 2025 11:59
@blcham blcham force-pushed the 332-fix-dependencies-in-core branch from 14e142b to 353fa80 Compare September 13, 2025 11:00
blcham and others added 2 commits September 14, 2025 23:55
@blcham
[#332] Fix missing logger in tests
82fbc1e 
Fixes error in tests:
```
SLF4J: No SLF4J providers were found.
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See https://www.slf4j.org/codes.html#noProviders for further details.
OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
```
[#332] Add logback dependency to the ignore list to avoid warnings
66a67f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blcham blcham Awaiting requested review from blcham

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MSattrtand @blcham